Skip to content

Commit 94e980c

Browse files
committed
src: use non-deprecated overload of V8::SetFlagsFromString
PR-URL: #28016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 1dd31fe commit 94e980c

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/node.cc

+4-2
Original file line numberDiff line numberDiff line change
@@ -945,7 +945,8 @@ void Init(int* argc,
945945
}
946946

947947
if (per_process::cli_options->print_v8_help) {
948-
V8::SetFlagsFromString("--help", 6); // Doesn't return.
948+
// Doesn't return.
949+
V8::SetFlagsFromString("--help", static_cast<size_t>(6));
949950
UNREACHABLE();
950951
}
951952

@@ -1002,7 +1003,8 @@ InitializationResult InitializeOncePerProcess(int argc, char** argv) {
10021003
}
10031004

10041005
if (per_process::cli_options->print_v8_help) {
1005-
V8::SetFlagsFromString("--help", 6); // Doesn't return.
1006+
// Doesn't return.
1007+
V8::SetFlagsFromString("--help", static_cast<size_t>(6));
10061008
UNREACHABLE();
10071009
}
10081010

src/node_v8.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ void UpdateHeapCodeStatisticsArrayBuffer(
139139
void SetFlagsFromString(const FunctionCallbackInfo<Value>& args) {
140140
CHECK(args[0]->IsString());
141141
String::Utf8Value flags(args.GetIsolate(), args[0]);
142-
V8::SetFlagsFromString(*flags, flags.length());
142+
V8::SetFlagsFromString(*flags, static_cast<size_t>(flags.length()));
143143
}
144144

145145

0 commit comments

Comments
 (0)