Skip to content

Commit 94746d6

Browse files
apapirovskitargos
authored andcommitted
test: remove outdated, non-functioning test
The timers directory test, utilizing FakeTime, has not worked in quite a while and is not truly testing Node.js behaviour. If a similar test is necessary it would be better suited to libuv on which Node.js relies for timers functionality. PR-URL: #20894 Fixes: #10154 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Backport-PR-URL: #22039 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
1 parent c6a56ae commit 94746d6

File tree

5 files changed

+0
-182
lines changed

5 files changed

+0
-182
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ deps/npm/node_modules/.bin/
107107
/SHASUMS*.txt*
108108

109109
# test artifacts
110-
tools/faketime
111110
tools/remark-cli/node_modules
112111
tools/remark-preset-lint-node/node_modules
113112
icu_config.gypi

Makefile

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -531,13 +531,6 @@ test-addons-clean:
531531
$(RM) test/addons/.buildstamp test/addons/.docbuildstamp
532532
$(MAKE) test-addons-napi-clean
533533

534-
test-timers:
535-
$(MAKE) --directory=tools faketime
536-
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) timers
537-
538-
test-timers-clean:
539-
$(MAKE) --directory=tools clean
540-
541534
test-async-hooks:
542535
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) async-hooks
543536

test/timers/test-timers-reliability.js

Lines changed: 0 additions & 54 deletions
This file was deleted.

test/timers/testcfg.py

Lines changed: 0 additions & 100 deletions
This file was deleted.

tools/Makefile

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)