esm: apply code review suggestions

- Refactor getUndefinedCJSGlobalLike to use ArrayPrototypeFind
- Change if-else chain to switch statement
- Add single quotes around global names in error messages
- Revert test file to use --input-type=module flag and original order
- Update test regex patterns to expect quoted global names

Author: mag123c

lib/internal/modules/esm/module_job.js

@@ -2,6 +2,7 @@
 
 const {
   Array,
+  ArrayPrototypeFind,
   ArrayPrototypeJoin,
   FunctionPrototype,
   ObjectSetPrototypeOf,
@@ -60,14 +61,11 @@ const CJSGlobalLike = [
   '__filename',
   '__dirname',
 ];
-const getUndefinedCJSGlobalLike = (errorMessage) => {
-  for (const globalLike of CJSGlobalLike) {
-    if (errorMessage === `${globalLike} is not defined`) {
-      return globalLike;
-    }
-  }
-  return null;
-};
+const getUndefinedCJSGlobalLike = (errorMessage) =>
+  ArrayPrototypeFind(
+    CJSGlobalLike,
+    (globalLike) => errorMessage === `${globalLike} is not defined`,
+  ) ?? null;
 
 
 /**
@@ -81,18 +79,24 @@ const explainCommonJSGlobalLikeNotDefinedError = (e, url, hasTopLevelAwait) => {
   if (e?.name === 'ReferenceError' && undefinedGlobal !== null) {
 
     if (hasTopLevelAwait) {
-      let advice = '';
-      if (undefinedGlobal === 'require') {
-        advice = 'replace require() with import';
-      } else if (undefinedGlobal === 'module' || undefinedGlobal === 'exports') {
-        advice = 'use export instead of module.exports/exports';
-      } else if (undefinedGlobal === '__filename') {
-        advice = 'use import.meta.filename instead';
-      } else if (undefinedGlobal === '__dirname') {
-        advice = 'use import.meta.dirname instead';
+      let advice;
+      switch (undefinedGlobal) {
+        case 'require':
+          advice = 'replace require() with import';
+          break;
+        case 'module':
+        case 'exports':
+          advice = 'use export instead of module.exports/exports';
+          break;
+        case '__filename':
+          advice = 'use import.meta.filename instead';
+          break;
+        case '__dirname':
+          advice = 'use import.meta.dirname instead';
+          break;
       }
 
-      e.message = `Cannot determine intended module format because both ${undefinedGlobal} and top-level await are present. If the code is intended to be CommonJS, wrap await in an async function. If the code is intended to be an ES module, ${advice}.`;
+      e.message = `Cannot determine intended module format because both '${undefinedGlobal}' and top-level await are present. If the code is intended to be CommonJS, wrap await in an async function. If the code is intended to be an ES module, ${advice}.`;
       e.code = 'ERR_AMBIGUOUS_MODULE_SYNTAX';
       return;
     }

test/es-module/test-esm-detect-ambiguous.mjs

@@ -283,7 +283,7 @@ describe('Module syntax detection', { concurrency: !process.env.TEST_PARALLEL },
 
       match(
         stderr,
-        /ReferenceError: Cannot determine intended module format because both require and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, replace require\(\) with import\./
+        /ReferenceError: Cannot determine intended module format because both 'require' and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, replace require\(\) with import\./
       );
       strictEqual(stdout, '');
       strictEqual(code, 1);
@@ -432,14 +432,15 @@ describe('cjs & esm ambiguous syntax case', () => {
     const { stderr, code, signal } = await spawnPromisified(
       process.execPath,
       [
+        '--input-type=module',
         '--eval',
-        `const fs = require('fs');\nawait 1;`,
+        `await 1;\nconst fs = require('fs');`,
       ]
     );
 
     match(
       stderr,
-      /ReferenceError: Cannot determine intended module format because both require and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, replace require\(\) with import\./
+      /ReferenceError: Cannot determine intended module format because both 'require' and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, replace require\(\) with import\./
     );
 
     strictEqual(code, 1);
@@ -457,7 +458,7 @@ describe('cjs & esm ambiguous syntax case', () => {
 
     match(
       stderr,
-      /ReferenceError: Cannot determine intended module format because both exports and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, use export instead of module\.exports\/exports\./
+      /ReferenceError: Cannot determine intended module format because both 'exports' and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, use export instead of module\.exports\/exports\./
     );
 
     strictEqual(code, 1);
@@ -475,7 +476,7 @@ describe('cjs & esm ambiguous syntax case', () => {
 
     match(
       stderr,
-      /ReferenceError: Cannot determine intended module format because both __filename and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, use import\.meta\.filename instead\./
+      /ReferenceError: Cannot determine intended module format because both '__filename' and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, use import\.meta\.filename instead\./
     );
 
     strictEqual(code, 1);
@@ -493,7 +494,7 @@ describe('cjs & esm ambiguous syntax case', () => {
 
     match(
       stderr,
-      /ReferenceError: Cannot determine intended module format because both __dirname and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, use import\.meta\.dirname instead\./
+      /ReferenceError: Cannot determine intended module format because both '__dirname' and top-level await are present\. If the code is intended to be CommonJS, wrap await in an async function\. If the code is intended to be an ES module, use import\.meta\.dirname instead\./
     );
 
     strictEqual(code, 1);