From 940e31784e26f4415e0f944ba66d25d1dcfd43f6 Mon Sep 17 00:00:00 2001 From: Keyhan Vakil Date: Sun, 7 Aug 2022 05:44:33 -0700 Subject: [PATCH] test: move tests with many workers to sequential These tests spawn many workers, which may be CPU intensive causing timeouts (see the referenced PR for more details). Let's move them to sequential. Refs: https://github.com/nodejs/node/pull/44090 PR-URL: https://github.com/nodejs/node/pull/44139 Reviewed-By: Luigi Pinca Reviewed-By: Santiago Gimeno --- .../test-worker-fshandles-error-on-termination.js | 0 .../test-worker-fshandles-open-close-on-termination.js | 0 .../test-worker-http2-stream-terminate.js | 2 +- 3 files changed, 1 insertion(+), 1 deletion(-) rename test/{parallel => sequential}/test-worker-fshandles-error-on-termination.js (100%) rename test/{parallel => sequential}/test-worker-fshandles-open-close-on-termination.js (100%) rename test/{parallel => sequential}/test-worker-http2-stream-terminate.js (96%) diff --git a/test/parallel/test-worker-fshandles-error-on-termination.js b/test/sequential/test-worker-fshandles-error-on-termination.js similarity index 100% rename from test/parallel/test-worker-fshandles-error-on-termination.js rename to test/sequential/test-worker-fshandles-error-on-termination.js diff --git a/test/parallel/test-worker-fshandles-open-close-on-termination.js b/test/sequential/test-worker-fshandles-open-close-on-termination.js similarity index 100% rename from test/parallel/test-worker-fshandles-open-close-on-termination.js rename to test/sequential/test-worker-fshandles-open-close-on-termination.js diff --git a/test/parallel/test-worker-http2-stream-terminate.js b/test/sequential/test-worker-http2-stream-terminate.js similarity index 96% rename from test/parallel/test-worker-http2-stream-terminate.js rename to test/sequential/test-worker-http2-stream-terminate.js index a2a1c020035eac..370961bec27923 100644 --- a/test/parallel/test-worker-http2-stream-terminate.js +++ b/test/sequential/test-worker-http2-stream-terminate.js @@ -5,7 +5,7 @@ if (!common.hasCrypto) const assert = require('assert'); const http2 = require('http2'); const makeDuplexPair = require('../common/duplexpair'); -const { Worker, parentPort } = require('worker_threads'); +const { parentPort, Worker } = require('worker_threads'); // This test ensures that workers can be terminated without error while // stream activity is ongoing, in particular the C++ function