Skip to content

Commit 93ca2f7

Browse files
jasnellMylesBorins
authored andcommitted
meta: allow vague objections to be dismissed
Explicitly allow vague objections to change requests to be dismissed if requests for clarification go unanswered PR-URL: #15233 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 92f41e5 commit 93ca2f7

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

COLLABORATOR_GUIDE.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,12 @@ All pull requests that modify executable code should be subjected to
9494
continuous integration tests on the
9595
[project CI server](https://ci.nodejs.org/).
9696

97+
If any Collaborator objects to a change *without giving any additional
98+
explanation or context*, and the objecting Collaborator fails to respond to
99+
explicit requests for explanation or context within a reasonable period of
100+
time, the objection may be dismissed. Note that this does not apply to
101+
objections that are explained.
102+
97103
#### Useful CI Jobs
98104

99105
* [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)

0 commit comments

Comments
 (0)