Skip to content

Commit 93c4820

Browse files
committed
Revert "doc: correct vcbuild options for windows testing"
This reverts commit ed9b6c1. PR-URL: #10839 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
1 parent 492163c commit 93c4820

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

BUILDING.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ Prerequisites:
122122
To run the tests:
123123

124124
```console
125-
> .\vcbuild nosign test
125+
> .\vcbuild test
126126
```
127127

128128
To test if Node.js was built correctly:
@@ -180,7 +180,7 @@ $ ./configure --with-intl=full-icu --download=all
180180
##### Windows:
181181

182182
```console
183-
> .\vcbuild nosign full-icu download-all
183+
> .\vcbuild full-icu download-all
184184
```
185185

186186
#### Building without Intl support
@@ -197,7 +197,7 @@ $ ./configure --without-intl
197197
##### Windows:
198198

199199
```console
200-
> .\vcbuild nosign without-intl
200+
> .\vcbuild without-intl
201201
```
202202

203203
#### Use existing installed ICU (Unix / OS X only):
@@ -240,7 +240,7 @@ First unpack latest ICU to `deps/icu`
240240
as `deps/icu` (You'll have: `deps/icu/source/...`)
241241

242242
```console
243-
> .\vcbuild nosign full-icu
243+
> .\vcbuild full-icu
244244
```
245245

246246
## Building Node.js with FIPS-compliant OpenSSL

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -170,19 +170,19 @@ $ ./configure && make -j4 test
170170
Windows:
171171

172172
```text
173-
.\vcbuild nosign test
173+
> vcbuild test
174174
```
175175

176176
(See the [BUILDING.md](./BUILDING.md) for more details.)
177177

178178
Make sure the linter is happy and that all tests pass. Please, do not submit
179179
patches that fail either check.
180180

181-
Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
181+
Running `make test`/`vcbuild test` will run the linter as well unless one or
182182
more tests fail.
183183

184184
If you want to run the linter without running tests, use
185-
`make lint`/`.\vcbuild nosign jslint`.
185+
`make lint`/`vcbuild jslint`.
186186

187187
If you are updating tests and just want to run a single test to check it, you
188188
can use this syntax to run it exactly as the test harness would:

0 commit comments

Comments
 (0)