Skip to content

Commit 91c0ea6

Browse files
committed
deps: V8: cherry-pick 19173cde61d8
Original commit message: Make TagRange build without __builtin_unreachable Guard the call with V8_HAS_BUILTIN_UNREACHABLE, if it's not available in the toolchain, skip the compiler hint so it still compiles. Co-Authored-By: StefanStojanovic <stefan.stojanovic@janeasystems.com> Refs: #61898 Change-Id: Ided07825644ffdd5b6aa7c6fa7f39ae3e62d2535 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8517724 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#110422} Refs: v8/v8@19173cd Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent ec0bb3e commit 91c0ea6

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
# Reset this number to 0 on major V8 upgrades.
4646
# Increment by one for each non-official patch applied to deps/v8.
47-
'v8_embedder_string': '-node.7',
47+
'v8_embedder_string': '-node.8',
4848

4949
##### V8 defaults for Node.js #####
5050

‎deps/v8/include/v8-internal.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ struct TagRange {
532532

533533
// Construct the inclusive tag range [first, last].
534534
constexpr TagRange(Tag first, Tag last) : first(first), last(last) {
535-
#ifdef V8_ENABLE_CHECKS
535+
#if defined(V8_ENABLE_CHECKS) && V8_HAS_BUILTIN_UNREACHABLE
536536
// This would typically be a DCHECK, but that's not available here.
537537
if (first > last) __builtin_unreachable(); // Invalid tag range.
538538
#endif

0 commit comments

Comments
 (0)