Skip to content

Commit 915b56b

Browse files
0xparasharMylesBorins
0xparashar
authored and
MylesBorins
committed
test: remove unused arguments from function
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: #14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
1 parent 55dc14e commit 915b56b

File tree

1 file changed

+16
-29
lines changed

1 file changed

+16
-29
lines changed

‎test/parallel/test-http-parser.js‎

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function newParser(type) {
3232
parser.url += url;
3333
};
3434

35-
parser[kOnHeadersComplete] = function(info) {
35+
parser[kOnHeadersComplete] = function() {
3636
};
3737

3838
parser[kOnBody] = function(b, start, len) {
@@ -76,8 +76,7 @@ function expectBody(expected) {
7676
const request = Buffer.from(`GET /hello HTTP/1.1${CRLF}${CRLF}`);
7777

7878
const onHeadersComplete = (versionMajor, versionMinor, headers,
79-
method, url, statusCode, statusMessage,
80-
upgrade, shouldKeepAlive) => {
79+
method, url) => {
8180
assert.strictEqual(versionMajor, 1);
8281
assert.strictEqual(versionMinor, 1);
8382
assert.strictEqual(method, methods.indexOf('GET'));
@@ -93,7 +92,7 @@ function expectBody(expected) {
9392
// thrown from parser.execute()
9493
//
9594

96-
parser[kOnHeadersComplete] = function(info) {
95+
parser[kOnHeadersComplete] = function() {
9796
throw new Error('hello world');
9897
};
9998

@@ -117,8 +116,7 @@ function expectBody(expected) {
117116
'pong');
118117

119118
const onHeadersComplete = (versionMajor, versionMinor, headers,
120-
method, url, statusCode, statusMessage,
121-
upgrade, shouldKeepAlive) => {
119+
method, url, statusCode, statusMessage) => {
122120
assert.strictEqual(method, undefined);
123121
assert.strictEqual(versionMajor, 1);
124122
assert.strictEqual(versionMinor, 1);
@@ -146,8 +144,7 @@ function expectBody(expected) {
146144
`HTTP/1.0 200 Connection established${CRLF}${CRLF}`);
147145

148146
const onHeadersComplete = (versionMajor, versionMinor, headers,
149-
method, url, statusCode, statusMessage,
150-
upgrade, shouldKeepAlive) => {
147+
method, url, statusCode, statusMessage) => {
151148
assert.strictEqual(versionMajor, 1);
152149
assert.strictEqual(versionMinor, 0);
153150
assert.strictEqual(method, undefined);
@@ -179,15 +176,14 @@ function expectBody(expected) {
179176

180177
let seen_body = false;
181178

182-
const onHeaders = (headers, url) => {
179+
const onHeaders = (headers) => {
183180
assert.ok(seen_body); // trailers should come after the body
184181
assert.deepStrictEqual(headers,
185182
['Vary', '*', 'Content-Type', 'text/plain']);
186183
};
187184

188185
const onHeadersComplete = (versionMajor, versionMinor, headers,
189-
method, url, statusCode, statusMessage,
190-
upgrade, shouldKeepAlive) => {
186+
method, url) => {
191187
assert.strictEqual(method, methods.indexOf('POST'));
192188
assert.strictEqual(url || parser.url, '/it');
193189
assert.strictEqual(versionMajor, 1);
@@ -221,8 +217,7 @@ function expectBody(expected) {
221217
CRLF);
222218

223219
const onHeadersComplete = (versionMajor, versionMinor, headers,
224-
method, url, statusCode, statusMessage,
225-
upgrade, shouldKeepAlive) => {
220+
method) => {
226221
assert.strictEqual(method, methods.indexOf('GET'));
227222
assert.strictEqual(versionMajor, 1);
228223
assert.strictEqual(versionMinor, 0);
@@ -250,8 +245,7 @@ function expectBody(expected) {
250245
CRLF);
251246

252247
const onHeadersComplete = (versionMajor, versionMinor, headers,
253-
method, url, statusCode, statusMessage,
254-
upgrade, shouldKeepAlive) => {
248+
method, url) => {
255249
assert.strictEqual(method, methods.indexOf('GET'));
256250
assert.strictEqual(url || parser.url, '/foo/bar/baz?quux=42#1337');
257251
assert.strictEqual(versionMajor, 1);
@@ -284,8 +278,7 @@ function expectBody(expected) {
284278
'foo=42&bar=1337');
285279

286280
const onHeadersComplete = (versionMajor, versionMinor, headers,
287-
method, url, statusCode, statusMessage,
288-
upgrade, shouldKeepAlive) => {
281+
method, url) => {
289282
assert.strictEqual(method, methods.indexOf('POST'));
290283
assert.strictEqual(url || parser.url, '/it');
291284
assert.strictEqual(versionMajor, 1);
@@ -322,8 +315,7 @@ function expectBody(expected) {
322315
'0' + CRLF);
323316

324317
const onHeadersComplete = (versionMajor, versionMinor, headers,
325-
method, url, statusCode, statusMessage,
326-
upgrade, shouldKeepAlive) => {
318+
method, url) => {
327319
assert.strictEqual(method, methods.indexOf('POST'));
328320
assert.strictEqual(url || parser.url, '/it');
329321
assert.strictEqual(versionMajor, 1);
@@ -360,8 +352,7 @@ function expectBody(expected) {
360352
'123456' + CRLF);
361353

362354
const onHeadersComplete = (versionMajor, versionMinor, headers,
363-
method, url, statusCode, statusMessage,
364-
upgrade, shouldKeepAlive) => {
355+
method, url) => {
365356
assert.strictEqual(method, methods.indexOf('POST'));
366357
assert.strictEqual(url || parser.url, '/it');
367358
assert.strictEqual(versionMajor, 1);
@@ -418,8 +409,7 @@ function expectBody(expected) {
418409

419410
function test(a, b) {
420411
const onHeadersComplete = (versionMajor, versionMinor, headers,
421-
method, url, statusCode, statusMessage,
422-
upgrade, shouldKeepAlive) => {
412+
method, url) => {
423413
assert.strictEqual(method, methods.indexOf('POST'));
424414
assert.strictEqual(url || parser.url, '/helpme');
425415
assert.strictEqual(versionMajor, 1);
@@ -475,8 +465,7 @@ function expectBody(expected) {
475465
'0' + CRLF);
476466

477467
const onHeadersComplete = (versionMajor, versionMinor, headers,
478-
method, url, statusCode, statusMessage,
479-
upgrade, shouldKeepAlive) => {
468+
method, url) => {
480469
assert.strictEqual(method, methods.indexOf('POST'));
481470
assert.strictEqual(url || parser.url, '/it');
482471
assert.strictEqual(versionMajor, 1);
@@ -527,8 +516,7 @@ function expectBody(expected) {
527516
'pong');
528517

529518
const onHeadersComplete1 = (versionMajor, versionMinor, headers,
530-
method, url, statusCode, statusMessage,
531-
upgrade, shouldKeepAlive) => {
519+
method, url) => {
532520
assert.strictEqual(method, methods.indexOf('PUT'));
533521
assert.strictEqual(url, '/this');
534522
assert.strictEqual(versionMajor, 1);
@@ -539,8 +527,7 @@ function expectBody(expected) {
539527
};
540528

541529
const onHeadersComplete2 = (versionMajor, versionMinor, headers,
542-
method, url, statusCode, statusMessage,
543-
upgrade, shouldKeepAlive) => {
530+
method, url) => {
544531
assert.strictEqual(method, methods.indexOf('POST'));
545532
assert.strictEqual(url, '/that');
546533
assert.strictEqual(versionMajor, 1);

0 commit comments

Comments
 (0)