From 9021b0d3fcac507b335bd1117155e555adbd7c28 Mon Sep 17 00:00:00 2001 From: GauthamBanasandra Date: Sun, 2 Dec 2018 15:11:27 +0530 Subject: [PATCH] src: remove icuDataDir from node config icuDataDir seems to be redundant as it is not used anywhere. Hence removing it. PR-URL: https://github.com/nodejs/node/pull/24780 Reviewed-By: Anna Henningsen Reviewed-By: Steven R Loomis Reviewed-By: Joyee Cheung --- src/node_config.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/node_config.cc b/src/node_config.cc index 1ba1fe9d277af5..edf738b6337878 100644 --- a/src/node_config.cc +++ b/src/node_config.cc @@ -49,10 +49,6 @@ static void Initialize(Local target, READONLY_TRUE_PROPERTY(target, "hasNodeOptions"); #endif - // TODO(addaleax): This seems to be an unused, private API. Remove it? - READONLY_STRING_PROPERTY(target, "icuDataDir", - per_process_opts->icu_data_dir); - #endif // NODE_HAVE_I18N_SUPPORT if (env->options()->preserve_symlinks)