From 8ffe04f5333cb862ee90e8031e5e56346ae49800 Mon Sep 17 00:00:00 2001
From: Myles Borins <mylesborins@google.com>
Date: Tue, 27 Nov 2018 17:46:59 -0500
Subject: [PATCH] test: verify order of error in h2 server stream

Currently the order of error / closing of an h2 stream is consistent
in 10.x, 11.x, and master. There appears to be an unexpected behavior
difference in 8.x. This test will be used to bisect the commit that will
fix this behavior change and ensure there are no future regressions.

PR-URL: https://github.com/nodejs/node/pull/24685
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/parallel/test-http2-error-order.js | 43 +++++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 test/parallel/test-http2-error-order.js

diff --git a/test/parallel/test-http2-error-order.js b/test/parallel/test-http2-error-order.js
new file mode 100644
index 00000000000000..8bf0f03dba8ea3
--- /dev/null
+++ b/test/parallel/test-http2-error-order.js
@@ -0,0 +1,43 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const { createServer, connect } = require('http2');
+
+const messages = [];
+const expected = [
+  'Stream:created',
+  'Stream:error',
+  'Stream:close',
+  'Request:error'
+];
+
+const server = createServer();
+
+server.on('stream', (stream) => {
+  messages.push('Stream:created');
+  stream
+    .on('close', () => messages.push('Stream:close'))
+    .on('error', (err) => messages.push('Stream:error'))
+    .respondWithFile('dont exist');
+});
+
+server.listen(0);
+
+const client = connect(`http://localhost:${server.address().port}`);
+const req = client.request();
+
+req.on('response', common.mustNotCall());
+
+req.on('error', () => {
+  messages.push('Request:error');
+  client.close();
+});
+
+client.on('close', common.mustCall(() => {
+  assert.deepStrictEqual(messages, expected);
+  server.close();
+}));