Skip to content

Commit

Permalink
test: add DISABLED_ prefix to commented out test
Browse files Browse the repository at this point in the history
Commit 95ab966 ("test: disable
MultipleEnvironmentsPerIsolate") commented out
MultipleEnvironmentsPerIsolate but it migth be better to disable
the test so that this gets reported and not forgotten:

   YOU HAVE 1 DISABLED TEST

PR-URL: #14317
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
danbev authored and addaleax committed Aug 1, 2017
1 parent 1a5927f commit 8fea174
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions test/cctest/test_environment.cc
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ TEST_F(EnvironmentTest, AtExitWithArgument) {
EXPECT_EQ(arg, cb_1_arg);
}

/*
TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) {
TEST_F(EnvironmentTest, DISABLED_MultipleEnvironmentsPerIsolate) {
const v8::HandleScope handle_scope(isolate_);
const Argv argv;
Env env1 {handle_scope, isolate_, argv};
Expand All @@ -101,7 +100,6 @@ TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) {
RunAtExit(*env2);
EXPECT_TRUE(called_cb_2);
}
*/

static void at_exit_callback1(void* arg) {
called_cb_1 = true;
Expand Down

0 comments on commit 8fea174

Please sign in to comment.