test: use aliases for smart pointers in fixture

PR-URL: #21419 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
nodejs · Jun 28, 2018 · 8f1aa3c · 8f1aa3c
1 parent 7e10697
commit 8f1aa3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/test/cctest/node_test_fixture.cc b/test/cctest/node_test_fixture.cc
@@ -2,5 +2,5 @@
 
 ArrayBufferUniquePtr NodeTestFixture::allocator{nullptr, nullptr};
 uv_loop_t NodeTestFixture::current_loop;
-std::unique_ptr<node::NodePlatform> NodeTestFixture::platform;
-std::unique_ptr<v8::TracingController> NodeTestFixture::tracing_controller;
+NodePlatformUniquePtr NodeTestFixture::platform;
+TracingControllerUniquePtr NodeTestFixture::tracing_controller;
diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h
@@ -55,12 +55,14 @@ struct Argv {
 
 using ArrayBufferUniquePtr = std::unique_ptr<node::ArrayBufferAllocator,
       decltype(&node::FreeArrayBufferAllocator)>;
+using TracingControllerUniquePtr = std::unique_ptr<v8::TracingController>;
+using NodePlatformUniquePtr = std::unique_ptr<node::NodePlatform>;
 
 class NodeTestFixture : public ::testing::Test {
  protected:
   static ArrayBufferUniquePtr allocator;
-  static std::unique_ptr<v8::TracingController> tracing_controller;
-  static std::unique_ptr<node::NodePlatform> platform;
+  static TracingControllerUniquePtr tracing_controller;
+  static NodePlatformUniquePtr platform;
   static uv_loop_t current_loop;
   v8::Isolate* isolate_;