Merge branch 'nodejs:main' into test-readline-interface-coverage

.eslintrc.js

@@ -337,6 +337,7 @@ module.exports = {
     TextEncoderStream: 'readable',
     TransformStream: 'readable',
     TransformStreamDefaultController: 'readable',
+    ShadowRealm: 'readable',
     SubtleCrypto: 'readable',
     WritableStream: 'readable',
     WritableStreamDefaultWriter: 'readable',

.github/CODEOWNERS

@@ -107,10 +107,8 @@
 
 /benchmark/misc/startup.js @nodejs/startup
 /src/node.cc @nodejs/startup
-/src/node_code_cache_stub.cc @nodejs/startup
 /src/node_native_module* @nodejs/startup
 /lib/internal/bootstrap/* @nodejs/startup
-/tools/code_cache/* @nodejs/startup
 /tools/snapshot/* @nodejs/startup
 
 # V8

.github/label-pr-config.yml

@@ -67,7 +67,7 @@ subSystemLabels:
   /^tools\/make-v8/: tools, v8 engine, needs-ci
   /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
   /^tools\/(code_cache|snapshot)/: needs-ci
-  /^tools\/build-addons.js/: needs-ci
+  /^tools\/build-addons.mjs/: needs-ci
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools

.github/workflows/authors.yml

@@ -15,16 +15,18 @@ jobs:
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
-      - run: tools/update-authors.js  # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
+      - run: tools/update-authors.mjs  # Run the AUTHORS tool
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:
           author: Node.js GitHub Bot <github-bot@iojs.org>
           body: >
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
-            `authors.yml` GitHub Action, which runs `tools/update-authors.js`.
+            `authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
           branch: actions/authors-update  # Custom branch *just* for this Action.
           commit-message: 'meta: update AUTHORS'
           labels: meta

.github/workflows/build-windows.yml

@@ -32,7 +32,7 @@ jobs:
     if: github.event.pull_request.draft == false
     strategy:
       matrix:
-        windows: [windows-2019, windows-2022]
+        windows: [windows-2019]
       fail-fast: false
     runs-on: ${{ matrix.windows }}
     steps:

.github/workflows/coverage-linux.yml

@@ -60,6 +60,6 @@ jobs:
       - name: Clean tmp
         run: rm -rf coverage/tmp && rm -rf out
       - name: Upload
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3
         with:
           directory: ./coverage

.github/workflows/coverage-windows.yml

@@ -33,7 +33,7 @@ env:
 jobs:
   coverage-windows:
     if: github.event.pull_request.draft == false
-    runs-on: windows-latest
+    runs-on: windows-2019
     steps:
       - uses: actions/checkout@v3
         with:
@@ -61,6 +61,6 @@ jobs:
       - name: Clean tmp
         run: npx rimraf ./coverage/tmp
       - name: Upload
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3
         with:
           directory: ./coverage

.github/workflows/find-inactive-collaborators.yml

@@ -30,7 +30,9 @@ jobs:
         run: tools/find-inactive-collaborators.mjs
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@v1
+        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.github/workflows/find-inactive-tsc.yml

@@ -39,7 +39,9 @@ jobs:
         run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@v1
+        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.github/workflows/license-builder.yml

@@ -15,7 +15,9 @@ jobs:
         with:
           persist-credentials: false
       - run: ./tools/license-builder.sh  # Run the license builder tool
-      - uses: gr2m/create-or-update-pull-request-action@v1.x  # Create a PR or update the Action's existing PR
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

.github/workflows/linters.yml

@@ -49,6 +49,44 @@ jobs:
         run: npx envinfo
       - name: Lint C/C++ files
         run: make lint-cpp
+  format-cpp:
+    if: ${{ github.event.pull_request.draft == false && github.base_ref == 'master' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+          persist-credentials: false
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v3
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Format C/C++ files
+        run: |
+          make format-cpp-build
+          # The `make format-cpp` error code is intentionally ignored here
+          # because it is irrelevant. We already check if the formatter produced
+          # a diff in the next line.
+          # Refs: https://github.com/nodejs/node/pull/42764
+          CLANG_FORMAT_START="$(git merge-base HEAD refs/remotes/origin/$GITHUB_BASE_REF)" \
+            make format-cpp || true
+          git --no-pager diff --exit-code && EXIT_CODE="$?" || EXIT_CODE="$?"
+          if [ "$EXIT_CODE" != "0" ]
+          then
+            echo
+            echo 'ERROR: Please run:'
+            echo
+            echo "  CLANG_FORMAT_START="$\(git merge-base HEAD ${GITHUB_BASE_REF}\)" make format-cpp"
+            echo
+            echo 'to format the commits in your branch.'
+            exit "$EXIT_CODE"
+          fi
   lint-js-and-md:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
@@ -118,15 +156,15 @@ jobs:
           persist-credentials: false
       - run: shellcheck -V
       - name: Lint Shell scripts
-        run: tools/lint-sh.js .
+        run: tools/lint-sh.mjs .
   lint-codeowners:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
         with:
           persist-credentials: false
-      - uses: mszostok/codeowners-validator@v0.6.0
+      - uses: mszostok/codeowners-validator@7f3f5e28c6d7b8dfae5731e54ce2272ca384592f
         with:
           checks: files,duppatterns
   lint-pr-url:

.github/workflows/notify-force-push.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Slack Notification
-        uses: rtCamp/action-slack-notify@master
+        uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7
         env:
           SLACK_COLOR: '#DE512A'
           SLACK_ICON: https://github.com/nodejs.png?size=48

.github/workflows/test-asan.yml

@@ -30,6 +30,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
+  ASAN_OPTIONS: intercept_tls_get_addr=0
   PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 

.github/workflows/tools.yml

@@ -80,7 +80,9 @@ jobs:
         with:
           persist-credentials: false
       - run: ${{ matrix.run }}
-      - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.mailmap

@@ -50,6 +50,7 @@ Ashley Maceli <ashley.maceli@gmail.com>
 Ashok Suthar <coderatlabs@gmail.com>
 Ashutosh Kumar Singh <singhjug1994@gmail.com>
 Atsuo Fukaya <fukayatsu@gmail.com>
+Austin Kelleher <austinlkelleher@gmail.com> <austin.kell47@gmail.com>
 Azard <azardf4yy@gmail.com> <330815461@qq.com>
 Ben Lugavere <b.lugavere@gmail.com>
 Ben Noordhuis <info@bnoordhuis.nl> <ben@strongloop.com>
@@ -82,11 +83,14 @@ Brian White <mscdex@mscdex.net> <mscdex@users.noreply.github.com>
 Caleb Boyd <caleb.boyd@gmail.com>
 Calvin Metcalf <calvin.metcalf@gmail.com> <calvin.metcalf@state.ma.us>
 Calvin Metcalf <calvin.metcalf@gmail.com> <cmetcalf@appgeo.com>
+Camillo Bruni <camillobruni@users.noreply.github.com> <cbruni@chromium.org>
 Caralyn Reisle <caralynreisle@gmail.com>
 Charles <ineedpracticing@gmail.com> <cydjudge@users.noreply.github.com>
 Charles Rudolph <charles.rudolph@originate.com>
 Chen Gang <gangc.cxy@foxmail.com>
 Chen Gang <gangc.cxy@foxmail.com> <13298548+MoonBall@users.noreply.github.com>
+Chengzhong Wu <legendecas@gmail.com>
+Chengzhong Wu <legendecas@gmail.com> <chengzhong.wcz@alibaba-inc.com>
 Chew Choon Keat <choonkeat@gmail.com>
 Chris Andrews <cpandrews8@gmail.com>
 Chris Johnson <chris.s.johnson4@gmail.com>
@@ -196,8 +200,6 @@ Hassaan Pasha <pasha.hassaan@gmail.com> <hassaan.pasha@teamo.io>
 Hendrik Schwalm <mail@hendrikschwalm.de>
 Henry Chin <hheennrryy@gmail.com>
 Herbert Vojčík <herby@mailbox.sk>
-himself65 <himself65@outlook.com> <himself65@mask.io>
-himself65 <himself65@outlook.com> <himself6565@gmail.com>
 Hitesh Kanwathirtha <hiteshk@microsoft.com> <digitalinfinity@gmail.com>
 Icer Liang <liangshuangde@163.com> <wizicer@users.noreply.github.com>
 Igor Savin <iselwin@gmail.com>
@@ -298,6 +300,7 @@ Lakshmi Swetha Gopireddy <lakshmiswethagopireddy@gmail.com> <lgopired@in.ibm.com
 Lars-Magnus Skog <ralphtheninja@riseup.net> <lars.magnus.skog@gmail.com>
 Lasse R.H. Nielsen <lrn@chromium.org>
 Leeseean Chiu <leeseean@qq.com>
+LiviaMedeiros <livia@cirno.name> <74449973+LiviaMedeiros@users.noreply.github.com>
 Lucas Pardue <lucaspardue.24.7@gmail.com> <lucas.pardue@bbc.co.uk>
 Luke Bayes <lbayes@patternpark.com>
 Lydia Kats <llkats@gmail.com>
@@ -356,6 +359,8 @@ Mitar Milutinovic <mitar.git@tnode.com>
 Mithun Sasidharan <mithunsasidharan89@gmail.com> <msasidharan@paypal.com>
 Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> <62040526+VoltrexMaster@users.noreply.github.com>
+Morgan Roderick <morgan@roderick.dk>
+Morgan Roderick <morgan@roderick.dk> <20321+mroderick@users.noreply.github.com>
 MURAKAMI Masahiko <m-murakami@esm.co.jp> <fossamagna2@gmail.com>
 Myles Borins <myles.borins@gmail.com> <mborins@us.ibm.com>
 Myles Borins <myles.borins@gmail.com> <mylesborins@github.com>
@@ -372,10 +377,17 @@ Nils Kuhnhenn <lain@volafile.io>
 Nitzan Uziely <linkgoron@gmail.com> <Linkgoron@users.noreply.github.com>
 Nitzan Uziely <linkgoron@gmail.com> <nitzan@testim.io>
 Noah Rose Ledesma <noahroseledesma@seattleacademy.org>
+npm team <ops+robot@npmjs.com>
+npm team <ops+robot@npmjs.com> <npm CLI robot>
+npm team <ops+robot@npmjs.com> <npm team>
+npm team <ops+robot@npmjs.com> <npm-cli+bot@github.com>
 Oliver Chang <ochang@chromium.org>
 Oluwaseun Omoyajowo <omoyajowo2015@gmail.com>
+OneNail <OneNail@yeah.net> <onenail@yeah.net>
 Onne Gorter <onne@onnlucky.com>
 Oscar Martinez <oscar@mtnz-web.com> <oscar.martinez@hautelook.com>
+Paolo Insogna <paolo@cowtech.it>
+Paolo Insogna <paolo@cowtech.it> <ShogunPanda@users.noreply.github.com>
 Paul Graham <homosaur@gmail.com> <paul@bytefair.com>
 Paul Querna <pquerna@apache.org> <paul@querna.org>
 Pedro Lima <pvsousalima@gmail.com>
@@ -558,6 +570,8 @@ Yuta Hiroto <git@about-hiroppy.com>
 Zach Bjornson <bjornson@stanford.edu> <zbbjornson@gmail.com>
 Zachary Scott <zachary@zacharyscott.net> <zachary.s.scott@gmail.com>
 Zachary Vacura <admin@hackzzila.com>
+Zeyu "Alex" Yang <himself65@outlook.com> <himself65@mask.io>
+Zeyu "Alex" Yang <himself65@outlook.com> <himself6565@gmail.com>
 Zoran Tomicic <ztomicic@gmail.com>
 Сковорода Никита Андреевич <chalkerx@gmail.com>
 隋鑫磊 <joshuasui@163.com>

AUTHORS

@@ -2310,12 +2310,12 @@ Dzmitry_Prudnikau <dzmitriyprudnikov@gmail.com>
 Ian McKellar <ianloic@google.com>
 Jennifer Bland <ratracegrad@gmail.com>
 Kyle Fuller <kyle@fuller.li>
-Camillo Bruni <cbruni@chromium.org>
+Camillo Bruni <camillobruni@users.noreply.github.com>
 Yongsheng Zhang <zyszys98@gmail.com>
 Neeraj Laad <neeraj.laad@uk.ibm.com>
 Scott Van Gilder <svangilder@gmail.com>
 Yaniv Friedensohn <yaniv.friedensohn@gmail.com>
-Lucas Woo <legendecas@gmail.com>
+Chengzhong Wu <legendecas@gmail.com>
 Troels Liebe Bentsen <troels@connectedcars.dk>
 pranshuchittora <pranshuchittora17@gmail.com>
 lakamsani <lakamsani@gmail.com>
@@ -2686,7 +2686,7 @@ Alexander Sattelmaier <alexander.sattelmaier@gmail.com>
 Avi ד <avi.the.coder@gmail.com>
 Thomas <hakerh403@gmail.com>
 Aymen Naghmouchi <aymen.aymen@live.it>
-himself65 <himself65@outlook.com>
+Zeyu "Alex" Yang <himself65@outlook.com>
 Patrick Gansterer <paroga@paroga.com>
 Nicolas Moteau <nicolas.moteau@orange.com>
 Anthony Tuininga <anthony.tuininga@oracle.com>
@@ -3260,7 +3260,6 @@ Siddharth <siddharth.muscat@gmail.com>
 Cactysman <git@cactys.dev>
 David Brownman <beamneocube@gmail.com>
 Michael Rommel <rommel@layer-7.net>
-Chengzhong Wu <chengzhong.wcz@alibaba-inc.com>
 Andres <and.atencio@gmail.com>
 Jayden Seric <me@jaydenseric.com>
 divlo <contact@divlo.fr>
@@ -3288,7 +3287,7 @@ pengjie <37610029@qq.com>
 Philip <phershbe@gmail.com>
 julianjany <54538266+julianjany@users.noreply.github.com>
 bl-ue <bl-ue@users.noreply.github.com>
-npm-robot <ops+robot@npmjs.com>
+npm team <ops+robot@npmjs.com>
 Shaun Keys <mariobuddy@gmail.com>
 Simone Busoli <simone.busoli@nearform.com>
 Derevianchenko Maksym <32910350+maks-white@users.noreply.github.com>
@@ -3430,9 +3429,8 @@ Derek Wolpert <48101033+derekwolpert@users.noreply.github.com>
 wbt <wbt@users.noreply.github.com>
 Alexandru Comanescu <comanescu.robert93@gmail.com>
 madflow <madflow@web.de>
-Austin Kelleher <austin.kell47@gmail.com>
+Austin Kelleher <austinlkelleher@gmail.com>
 apeltop <sunshine@ptokos.com>
-Livia Medeiros <74449973+LiviaMedeiros@users.noreply.github.com>
 Nikolaos Papaspyrou <nikolaos@chromium.org>
 Matt Probert <1196252+mattpr@users.noreply.github.com>
 Roch Devost <roch.devost@gmail.com>
@@ -3452,5 +3450,23 @@ Daeyeon Jeong <daeyeon.dev@gmail.com>
 Daniel Roe <daniel@roe.dev>
 Niyas Sait <niyas.sait@linaro.org>
 K.C.Ashish Kumar <703559+kcak11@users.noreply.github.com>
+Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
+Liviu Ionescu <ilg@livius.net>
+HE Shi-Jun <hax@heshijun.net>
+Yagiz Nizipli <yagiz@nizipli.com>
+liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
+Sergey Nazaryev <sergey@nazaryev.com>
+William Marlow <william.marlow@ibm.com>
+Keyhan Vakil <60900335+airtable-keyhanvakil@users.noreply.github.com>
+Feng Yu <F3n67u@outlook.com>
+pupilTong <pupiltong@outlook.com>
+rikapo <rikaporori@gmail.com>
+Meek Simbule <55823259+meekdenzo@users.noreply.github.com>
+Michael Ficarra <github@michael.ficarra.me>
+hiroki osame <hiroki.osame@gmail.com>
+Eugene Chapko <eugene.chapko@gmail.com>
+Sergey Petushkov <sergey.petushkov@protonmail.com>
+Caleb Everett <everett.caleb@gmail.com>
+JialuZhang-intel <jialu.zhang@intel.com>
 
-# Generated by tools/update-authors.js
+# Generated by tools/update-authors.mjs