Skip to content

Commit

Permalink
test: update flag to disable SharedArrayBuffer
Browse files Browse the repository at this point in the history
`--no-harmony-sharedarraybuffer` was removed from V8 but it's still
possible to disable the feature with
`--enable-sharedarraybuffer-per-context`.

PR-URL: #49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
targos committed Oct 10, 2023
1 parent 6ccb15f commit 8c36168
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/internal/worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ let cwdCounter;

const environmentData = new SafeMap();

// SharedArrayBuffers can be disabled with --no-harmony-sharedarraybuffer.
// SharedArrayBuffers can be disabled with --enable-sharedarraybuffer-per-context.
if (isMainThread && SharedArrayBuffer !== undefined) {
cwdCounter = new Uint32Array(new SharedArrayBuffer(4));
const originalChdir = process.chdir;
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-worker-no-sab.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Flags: --no-harmony-sharedarraybuffer
// Flags: --enable-sharedarraybuffer-per-context

'use strict';

Expand Down

0 comments on commit 8c36168

Please sign in to comment.