From 8a2b4ee7bbb967f88f76792c6daa29d49ccc79d6 Mon Sep 17 00:00:00 2001 From: Toon Verwaest Date: Fri, 27 Oct 2017 17:41:07 +0200 Subject: [PATCH] src: remove unnecessary call to SetHiddenPrototype Currently the template for the global object is explicitly marked as hidden. This is unnecessary since the global object is automatically marked as hidden by V8. Getting rid of this call gets rid of the last use of SetHiddenPrototype. PR-URL: https://github.com/nodejs/node/pull/16554 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell Reviewed-By: Timothy Gu Reviewed-By: Franziska Hinkelmann --- src/node_contextify.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 91793457029cb0..678ba70f033e51 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -139,7 +139,6 @@ class ContextifyContext { EscapableHandleScope scope(env->isolate()); Local function_template = FunctionTemplate::New(env->isolate()); - function_template->SetHiddenPrototype(true); function_template->SetClassName(sandbox_obj->GetConstructorName());