Skip to content

Commit 88c91bf

Browse files
committed
src: disable concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: #47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
1 parent 0e79635 commit 88c91bf

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/node.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -790,6 +790,10 @@ static ExitCode InitializeNodeWithArgsInternal(
790790
// is security relevant, for Node it's less important.
791791
V8::SetFlagsFromString("--no-freeze-flags-after-init");
792792

793+
// TODO(targos): Remove when https://github.com/nodejs/node/issues/47297 is
794+
// fixed.
795+
V8::SetFlagsFromString("--no-concurrent-sparkplug");
796+
793797
#if defined(NODE_V8_OPTIONS)
794798
// Should come before the call to V8::SetFlagsFromCommandLine()
795799
// so the user can disable a flag --foo at run-time by passing

0 commit comments

Comments
 (0)