Skip to content

Commit

Permalink
build: update manifest to include Windows 10
Browse files Browse the repository at this point in the history
This is a port of b0dd3bf .

Original commit message:

  Windows 10 wasn't listed in the executable manifest.
  This caused problems with trying to detect Windows 10
  via `os.release()`.

  PR-URL: #2332
  Reviewed-By: Roman Reiss <me@silverwind.io>

PR-URL: #2843
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
LPGhatguy authored and joaocgreis committed Sep 16, 2015
1 parent 08afe4e commit 8887666
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/res/node.exe.extra.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
<application>
<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
<!-- Windows 8.1 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
<!-- Windows 8 -->
Expand Down

0 comments on commit 8887666

Please sign in to comment.