From 879e60ae3686b936d644af712cd2dfcaba79ff7e Mon Sep 17 00:00:00 2001 From: gengjiawen Date: Wed, 27 Feb 2019 23:12:33 +0800 Subject: [PATCH] lib: improve for-loop in master.js --- lib/internal/cluster/master.js | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/lib/internal/cluster/master.js b/lib/internal/cluster/master.js index a0e194c63ef3c3..3869ebbd8a40a2 100644 --- a/lib/internal/cluster/master.js +++ b/lib/internal/cluster/master.js @@ -80,10 +80,7 @@ cluster.setupMaster = function(options) { if (message.cmd !== 'NODE_DEBUG_ENABLED') return; - var key; - for (key in cluster.workers) { - const worker = cluster.workers[key]; - + for (const worker of Object.values(cluster.workers)) { if (worker.state === 'online' || worker.state === 'listening') { process._debugProcess(worker.process.pid); } else { @@ -227,11 +224,10 @@ cluster.disconnect = function(cb) { if (workers.length === 0) { process.nextTick(() => intercom.emit('disconnect')); } else { - for (var key in workers) { - key = workers[key]; - - if (cluster.workers[key].isConnected()) - cluster.workers[key].disconnect(); + for (const worker of Object.values(cluster.workers)) { + if (worker.isConnected()) { + worker.disconnect(); + } } }