From 8712edf53a5f71f183a6a49b364d2bcb439d00ff Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Tue, 16 Apr 2019 16:27:28 -0700 Subject: [PATCH] test: fix postmortem metadata test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Recent changes to spawnSync (https://github.com/nodejs/node/pull/23027) broke our V8 postmortem tests since the output from nm was larger than the new default maxBuffer for spawnSync. Changing the maxBuffer to Infinity fixes the issue. PR-URL: https://github.com/nodejs/node/pull/27265 Refs: https://github.com/v8/v8/compare/7.4.288.18...7.4.288.21 Reviewed-By: Ruben Bridgewater Reviewed-By: Michaël Zasso Reviewed-By: Colin Ihrig --- test/v8-updates/test-postmortem-metadata.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index cce4a4d2279652..c6704ef1e34bc2 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -21,7 +21,7 @@ if (common.isAIX) if (common.isOpenBSD) common.skip('no v8 debug symbols on OpenBSD'); -const nm = spawnSync('nm', args); +const nm = spawnSync('nm', args, { maxBuffer: Infinity }); if (nm.error && nm.error.errno === 'ENOENT') common.skip('nm not found on system');