fixup: add exists to DeserializedPackageConfig

Author: JakobJingleheimer

lib/internal/modules/package_json_reader.js

@@ -40,6 +40,7 @@ function deserializePackageJSON(path, contents) {
         __proto__: null,
         type: 'none', // Ignore unknown types for forwards compatibility
       },
+      exists: false,
       path,
     };
   }
@@ -78,6 +79,7 @@ function deserializePackageJSON(path, contents) {
         },
       }),
     },
+    exists: true,
     path: pjsonPath,
   };
 }
@@ -112,7 +114,7 @@ function read(jsonPath, { base, specifier, isESM } = kEmptyObject) {
   return {
     __proto__: null,
     ...result.data,
-    exists: result.data !== 'none',
+    exists: result.exists,
     pjsonPath: result.path,
   };
 }
@@ -164,6 +166,7 @@ function getNearestParentPackageJSON(startLocation, everything = false) {
         __proto__: null,
         ...JSONParse(result?.[0]),
       },
+      exists: true,
       path: result?.[1],
     };
   }
@@ -189,10 +192,12 @@ function getPackageScopeConfig(resolved) {
   const result = modulesBinding.getPackageScopeConfig(`${resolved}`);
 
   if (ArrayIsArray(result)) {
-    const { data, path } = deserializePackageJSON(`${resolved}`, result);
+    const { data, exists, path } = deserializePackageJSON(`${resolved}`, result);
+
     return {
       __proto__: null,
       ...data,
+      exists,
       pjsonPath: path,
     };
   }

test/parallel/test-get-package-json.js

@@ -31,6 +31,7 @@ const pkgType = 'module'; // a non-default value
 
   assert.deepStrictEqual(pkg, {
     path: path.join(pathToDir, 'package.json'),
+    exists: true,
     data: {
       __proto__: null,
       name: pkgName,
@@ -45,6 +46,7 @@ const pkgType = 'module'; // a non-default value
 
   assert.deepStrictEqual(pkg, {
     path: path.join(pathToDir, 'package.json'),
+    exists: true,
     data: {
       __proto__: null,
       name: pkgName,
@@ -59,6 +61,7 @@ const pkgType = 'module'; // a non-default value
 
   assert.deepStrictEqual(pkg, {
     path: path.join(pathToDir, 'package.json'),
+    exists: true,
     data: {
       __proto__: null,
       name: pkgName,
@@ -74,6 +77,7 @@ const pkgType = 'module'; // a non-default value
 
   assert.deepStrictEqual(pkg, {
     path: path.join(pathToDir, 'package.json'),
+    exists: true,
     data: {
       __proto__: null,
       name: pkgName,
@@ -92,6 +96,7 @@ const pkgType = 'module'; // a non-default value
 
   assert.deepStrictEqual(pkg, {
     path: path.join(pathToDir, 'package.json'),
+    exists: true,
     data: {
       __proto__: null,
       name: pkgName,

typings/internalBinding/modules.d.ts

@@ -10,7 +10,8 @@ export type FullPackageConfig = RecognizedPackageConfig & {
   [key: string]: unknown,
 }
 export type DeserializedPackageConfig<everything = false> = {
-  data: everything extends true ? FullPackageConfig : RecognizedPackageConfig
+  data: everything extends true ? FullPackageConfig : RecognizedPackageConfig,
+  exists: boolean,
   path: URL['pathname'],
 }
 export type SerializedPackageConfig = [