Skip to content

Commit 8455b62

Browse files
aduh95juanarbol
authored andcommitted
stream: remove unnecessary check
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 8050660 commit 8455b62

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

lib/internal/webstreams/util.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,11 @@ const AsyncIterator = {
5959

6060
function extractHighWaterMark(value, defaultHWM) {
6161
if (value === undefined) return defaultHWM;
62-
value = +value;
63-
if (typeof value !== 'number' ||
64-
NumberIsNaN(value) ||
65-
value < 0)
62+
const coercedValue = +value;
63+
if (NumberIsNaN(coercedValue) ||
64+
coercedValue < 0)
6665
throw new ERR_INVALID_ARG_VALUE.RangeError('strategy.highWaterMark', value);
67-
return value;
66+
return coercedValue;
6867
}
6968

7069
function extractSizeAlgorithm(size) {
@@ -156,13 +155,13 @@ function peekQueueValue(controller) {
156155
function enqueueValueWithSize(controller, value, size) {
157156
assert(controller[kState].queue !== undefined);
158157
assert(controller[kState].queueTotalSize !== undefined);
159-
size = +size;
160-
if (typeof size !== 'number' ||
161-
size < 0 ||
162-
NumberIsNaN(size) ||
163-
size === Infinity) {
158+
const coercedSize = +size;
159+
if (NumberIsNaN(coercedSize) ||
160+
coercedSize < 0 ||
161+
coercedSize === Infinity) {
164162
throw new ERR_INVALID_ARG_VALUE.RangeError('size', size);
165163
}
164+
size = coercedSize;
166165
ArrayPrototypePush(controller[kState].queue, { value, size });
167166
controller[kState].queueTotalSize += size;
168167
}

0 commit comments

Comments
 (0)