Skip to content

Commit 83ff7be

Browse files
anonrigtargos
authored andcommitted
src: disallow copy/move fns/constructors
PR-URL: #56811 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent ccaf7fe commit 83ff7be

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/debug_utils-inl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ struct ToStringHelper {
5050
template <unsigned BASE_BITS,
5151
typename T,
5252
typename = std::enable_if_t<!std::is_integral_v<T>>>
53-
static std::string BaseConvert(T value) {
53+
static std::string BaseConvert(T& value) { // NOLINT(runtime/references)
5454
return Convert(std::forward<T>(value));
5555
}
5656
};

src/util.h

+5
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,11 @@ constexpr size_t strsize(const T (&)[N]) {
388388
template <typename T, size_t kStackStorageSize = 1024>
389389
class MaybeStackBuffer {
390390
public:
391+
// Disallow copy constructor
392+
MaybeStackBuffer(const MaybeStackBuffer&) = delete;
393+
// Disallow copy assignment operator
394+
MaybeStackBuffer& operator=(const MaybeStackBuffer& other) = delete;
395+
391396
const T* out() const {
392397
return buf_;
393398
}

0 commit comments

Comments
 (0)