Skip to content

Commit 82afb4c

Browse files
sagirktargos
authored andcommitted
test: remove message argument from strictEqual()
In test/parallel/test-require-process.js, the last thing in the test is a call to assert.strictEqual(). It has a string literal as its third argument. Unfortunately, that means that the diff between the two values being compared will be suppressed if there is an AssertionError. That's not helpful for debugging. This is fixed by removing the third argument from the call. It is, however, preserved in a comment above the call to assert.strictEqual(). PR-URL: #20912 Fixes: #20911 Refs: https://www.nodetodo.org/getting-started Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 40e5788 commit 82afb4c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-require-process.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ require('../common');
33
const assert = require('assert');
44

55
const nativeProcess = require('process');
6-
assert.strictEqual(nativeProcess, process,
7-
'require("process") should return global process reference');
6+
// require('process') should return global process reference
7+
assert.strictEqual(nativeProcess, process);

0 commit comments

Comments
 (0)