Skip to content

Commit 81e9a3b

Browse files
ofrobotsMylesBorins
authored andcommitted
deps: V8: fix debug backtrace for symbols
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: #7612 Ref: #9298 PR-URL: #10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent cfa2b87 commit 81e9a3b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 4
1212
#define V8_MINOR_VERSION 5
1313
#define V8_BUILD_NUMBER 103
14-
#define V8_PATCH_LEVEL 43
14+
#define V8_PATCH_LEVEL 44
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/mirror-debugger.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1515,7 +1515,7 @@ PropertyMirror.prototype.name = function() {
15151515

15161516

15171517
PropertyMirror.prototype.toText = function() {
1518-
if (IS_SYMBOL(this.name_)) return %SymbolDescriptiveString(this.name_);
1518+
if (IS_SYMBOL(this.name_)) return %SymbolDescription(this.name_);
15191519
return this.name_;
15201520
};
15211521

deps/v8/test/mjsunit/debug-backtrace-text.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ function listener(event, exec_state, event_data, data) {
106106
// 2: [anonymous]
107107
assertEquals("new Point(x=0, y=0)",
108108
exec_state.frame(0).invocationText());
109-
assertEquals("#<Object>[Symbol(Das Symbol)](x=0, y=0)",
109+
assertEquals("#<Object>[Das Symbol](x=0, y=0)",
110110
exec_state.frame(1).invocationText());
111111
assertEquals("[anonymous]()", exec_state.frame(2).invocationText());
112112
listenerCalled = true;

0 commit comments

Comments
 (0)