From 7ebd6bdf87cd816c419edaaf86ca13f78969513d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 18 Mar 2019 05:55:43 -0700 Subject: [PATCH] test: optimize test-http2-large-file Optimize test-http2-large-file so it only allocates a single buffer. PR-URL: https://github.com/nodejs/node/pull/26737 Reviewed-By: Matteo Collina Reviewed-By: Yongsheng Zhang Reviewed-By: Adrian Estrada --- test/sequential/test-http2-large-file.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/sequential/test-http2-large-file.js b/test/sequential/test-http2-large-file.js index d1a44e8d6be53c..2f2cc2c80d1db5 100644 --- a/test/sequential/test-http2-large-file.js +++ b/test/sequential/test-http2-large-file.js @@ -1,6 +1,6 @@ 'use strict'; -// Test to ensure sending a large stream with a large initial window size works +// Test sending a large stream with a large initial window size. // See: https://github.com/nodejs/node/issues/19141 const common = require('../common'); @@ -18,14 +18,15 @@ server.on('stream', (stream) => { server.listen(0, common.mustCall(() => { let remaining = 1e8; - const chunk = 1e6; + const chunkLength = 1e6; + const chunk = Buffer.alloc(chunkLength, 'a'); const client = http2.connect(`http://localhost:${server.address().port}`, { settings: { initialWindowSize: 6553500 } }); const request = client.request({ ':method': 'POST' }); function writeChunk() { if (remaining > 0) { - remaining -= chunk; - request.write(Buffer.alloc(chunk, 'a'), writeChunk); + remaining -= chunkLength; + request.write(chunk, writeChunk); } else { request.end(); }