Skip to content

Commit 7d1918b

Browse files
benjamingrFishrock123
authored andcommitted
dns: use template literals
Prefer the use of template string literals over string concatenation in the dns module, makes dns consistent with other modules basically doing #5778 for it. PR-URL: #5809 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ca971b0 commit 7d1918b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/dns.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ function errnoException(err, syscall, hostname) {
2222
}
2323
var ex = null;
2424
if (typeof err === 'string') { // c-ares error code.
25-
ex = new Error(syscall + ' ' + err + (hostname ? ' ' + hostname : ''));
25+
const errHost = hostname ? ' ' + hostname : '';
26+
ex = new Error(`${syscall} ${err}${errHost}`);
2627
ex.code = err;
2728
ex.errno = err;
2829
ex.syscall = syscall;
@@ -267,7 +268,7 @@ exports.resolve = function(hostname, type_, callback_) {
267268
if (typeof resolver === 'function') {
268269
return resolver(hostname, callback);
269270
} else {
270-
throw new Error('Unknown type "' + type_ + '"');
271+
throw new Error(`Unknown type "${type_}"`);
271272
}
272273
};
273274

@@ -305,7 +306,7 @@ exports.setServers = function(servers) {
305306
if (ver)
306307
return newSet.push([ver, s]);
307308

308-
throw new Error('IP address is not properly formatted: ' + serv);
309+
throw new Error(`IP address is not properly formatted: ${serv}`);
309310
});
310311

311312
var r = cares.setServers(newSet);
@@ -315,8 +316,7 @@ exports.setServers = function(servers) {
315316
cares.setServers(orig.join(','));
316317

317318
var err = cares.strerror(r);
318-
throw new Error('c-ares failed to set servers: "' + err +
319-
'" [' + servers + ']');
319+
throw new Error(`c-ares failed to set servers: "${err}" [${servers}]`);
320320
}
321321
};
322322

0 commit comments

Comments
 (0)