benchmark: inherit stdio/stderr instead of pipe

PR-URL: #52456 Fixes: #52233 Refs: nodejs/performance#161 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
nodejs · Apr 29, 2024 · 7cdfe8a · 7cdfe8a
1 parent 7b82c17
commit 7cdfe8a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/benchmark/compare.js b/benchmark/compare.js
@@ -83,11 +83,8 @@ if (showProgress) {
     const spawnArgs = ['-c', cpuCore, cli.optional[job.binary], resolvedPath, ...cli.optional.set];
     child = spawn('taskset', spawnArgs, {
       env: process.env,
-      stdio: ['inherit', 'pipe', 'pipe', 'ipc'],
+      stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
     });
-
-    child.stdout.pipe(process.stdout);
-    child.stderr.pipe(process.stderr);
   } else {
     child = fork(resolvedPath, cli.optional.set, {
       execPath: cli.optional[job.binary],

diff --git a/benchmark/run.js b/benchmark/run.js
@@ -54,11 +54,8 @@ if (format === 'csv') {
   let child;
   if (cpuCore !== null) {
     child = spawn('taskset', ['-c', cpuCore, 'node', scriptPath, ...args], {
-      stdio: ['inherit', 'pipe', 'pipe', 'ipc'],
+      stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
     });
-
-    child.stdout.pipe(process.stdout);
-    child.stderr.pipe(process.stderr);
   } else {
     child = fork(
       scriptPath,