Skip to content

Commit 79e0812

Browse files
richardlaumarco-ippolito
authored andcommitted
build: use glob for dependencies of out/Makefile
The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: #55789 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent 39925de commit 79e0812

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ with-code-cache test-code-cache:
171171
$(warning '$@' target is a noop)
172172

173173
out/Makefile: config.gypi common.gypi node.gyp \
174-
deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \
175-
deps/simdutf/simdutf.gyp deps/ada/ada.gyp \
174+
deps/*/*.gyp \
176175
tools/v8_gypfiles/toolchain.gypi tools/v8_gypfiles/features.gypi \
177176
tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp
178177
$(PYTHON) tools/gyp_node.py -f make

0 commit comments

Comments
 (0)