Skip to content

Commit 7478ed0

Browse files
lutaoktargos
lutaok
authored and
targos
committed
tools: order dependency jobs alphabetically
Refs: nodejs/security-wg#973 PR-URL: #48184 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
1 parent 15336c3 commit 7478ed0

File tree

1 file changed

+95
-93
lines changed

1 file changed

+95
-93
lines changed

‎.github/workflows/tools.yml‎

Lines changed: 95 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ on:
2828
- libuv
2929
- lint-md-dependencies
3030
- llhttp
31+
- minimatch
3132
- nghttp2
3233
- nghttp3
3334
- ngtcp2
@@ -36,6 +37,7 @@ on:
3637
- simdutf
3738
- undici
3839
- uvwasi
40+
- zlib
3941

4042
env:
4143
PYTHON_VERSION: '3.11'
@@ -51,67 +53,27 @@ jobs:
5153
fail-fast: false # Prevent other jobs from aborting if one fails
5254
matrix:
5355
include:
54-
- id: eslint
55-
subsystem: tools
56-
label: tools
56+
- id: acorn
57+
subsystem: deps
58+
label: dependencies
5759
run: |
58-
./tools/dep_updaters/update-eslint.sh > temp-output
60+
./tools/dep_updaters/update-acorn.sh > temp-output
5961
cat temp-output
6062
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
6163
rm temp-output
62-
- id: corepack
63-
subsystem: deps
64-
label: dependencies
65-
run: |
66-
make corepack-update
67-
echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV
68-
- id: lint-md-dependencies
69-
subsystem: tools
70-
label: tools
71-
run: |
72-
cd tools/lint-md
73-
npm ci
74-
NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
75-
if [ "$NEW_VERSION" != "" ]; then
76-
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
77-
rm -rf package-lock.json node_modules
78-
# Include $NEW_VERSION to explicitly update the package.json
79-
# entry for the dependency and also so that semver-major updates
80-
# are not skipped.
81-
npm install --ignore-scripts $NEW_VERSION
82-
npm install --ignore-scripts
83-
cd ../..
84-
make lint-md-rollup
85-
fi
86-
- id: doc
87-
subsystem: tools
88-
label: tools
89-
run: |
90-
cd tools/doc
91-
npm ci
92-
NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
93-
if [ "$NEW_VERSION" != "" ]; then
94-
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
95-
rm -rf package-lock.json node_modules
96-
# Include $NEW_VERSION to explicitly update the package.json
97-
# entry for the dependency and also so that semver-major updates
98-
# are not skipped.
99-
npm install --ignore-scripts $NEW_VERSION
100-
npm install --ignore-scripts
101-
fi
102-
- id: undici
64+
- id: acorn-walk
10365
subsystem: deps
10466
label: dependencies
10567
run: |
106-
./tools/dep_updaters/update-undici.sh > temp-output
68+
./tools/dep_updaters/update-acorn-walk.sh > temp-output
10769
cat temp-output
10870
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
10971
rm temp-output
110-
- id: postject
111-
subsystem: deps,test
112-
label: test
72+
- id: ada
73+
subsystem: deps
74+
label: dependencies
11375
run: |
114-
./tools/dep_updaters/update-postject.sh > temp-output
76+
./tools/dep_updaters/update-ada.sh > temp-output
11577
cat temp-output
11678
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
11779
rm temp-output
@@ -123,96 +85,131 @@ jobs:
12385
cat temp-output
12486
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
12587
rm temp-output
126-
- id: acorn
88+
- id: brotli
12789
subsystem: deps
12890
label: dependencies
12991
run: |
130-
./tools/dep_updaters/update-acorn.sh > temp-output
92+
./tools/dep_updaters/update-brotli.sh > temp-output
13193
cat temp-output
13294
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
13395
rm temp-output
134-
- id: acorn-walk
96+
- id: c-ares
13597
subsystem: deps
13698
label: dependencies
13799
run: |
138-
./tools/dep_updaters/update-acorn-walk.sh > temp-output
100+
./tools/dep_updaters/update-c-ares.sh > temp-output
139101
cat temp-output
140102
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
141103
rm temp-output
142-
- id: libuv
104+
- id: cjs-module-lexer
143105
subsystem: deps
144106
label: dependencies
145107
run: |
146-
./tools/dep_updaters/update-libuv.sh > temp-output
108+
./tools/dep_updaters/update-cjs-module-lexer.sh > temp-output
147109
cat temp-output
148110
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
149111
rm temp-output
150-
- id: simdutf
112+
- id: corepack
151113
subsystem: deps
152114
label: dependencies
153115
run: |
154-
./tools/dep_updaters/update-simdutf.sh > temp-output
116+
make corepack-update
117+
echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV
118+
- id: doc
119+
subsystem: tools
120+
label: tools
121+
run: |
122+
cd tools/doc
123+
npm ci
124+
NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
125+
if [ "$NEW_VERSION" != "" ]; then
126+
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
127+
rm -rf package-lock.json node_modules
128+
# Include $NEW_VERSION to explicitly update the package.json
129+
# entry for the dependency and also so that semver-major updates
130+
# are not skipped.
131+
npm install --ignore-scripts $NEW_VERSION
132+
npm install --ignore-scripts
133+
fi
134+
- id: eslint
135+
subsystem: tools
136+
label: tools
137+
run: |
138+
./tools/dep_updaters/update-eslint.sh > temp-output
155139
cat temp-output
156140
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
157141
rm temp-output
158-
- id: ada
142+
- id: googletest
159143
subsystem: deps
160-
label: dependencies
144+
label: dependencies, test
161145
run: |
162-
./tools/dep_updaters/update-ada.sh > temp-output
146+
./tools/dep_updaters/update-googletest.sh > temp-output
163147
cat temp-output
164148
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
165149
rm temp-output
166-
- id: nghttp2
150+
- id: icu
167151
subsystem: deps
168-
label: dependencies
152+
label: dependencies, test
169153
run: |
170-
./tools/dep_updaters/update-nghttp2.sh > temp-output
154+
./tools/dep_updaters/update-icu.sh > temp-output
171155
cat temp-output
172156
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
173157
rm temp-output
174-
- id: llhttp
158+
- id: libuv
175159
subsystem: deps
176160
label: dependencies
177161
run: |
178-
./tools/dep_updaters/update-llhttp.sh > temp-output
162+
./tools/dep_updaters/update-libuv.sh > temp-output
179163
cat temp-output
180164
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
181165
rm temp-output
182-
- id: c-ares
166+
- id: lint-md-dependencies
167+
subsystem: tools
168+
label: tools
169+
run: |
170+
cd tools/lint-md
171+
npm ci
172+
NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
173+
if [ "$NEW_VERSION" != "" ]; then
174+
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
175+
rm -rf package-lock.json node_modules
176+
# Include $NEW_VERSION to explicitly update the package.json
177+
# entry for the dependency and also so that semver-major updates
178+
# are not skipped.
179+
npm install --ignore-scripts $NEW_VERSION
180+
npm install --ignore-scripts
181+
cd ../..
182+
make lint-md-rollup
183+
fi
184+
- id: llhttp
183185
subsystem: deps
184186
label: dependencies
185187
run: |
186-
./tools/dep_updaters/update-c-ares.sh > temp-output
188+
./tools/dep_updaters/update-llhttp.sh > temp-output
187189
cat temp-output
188190
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
189191
rm temp-output
190-
- id: brotli
192+
- id: minimatch
191193
subsystem: deps
192194
label: dependencies
193195
run: |
194-
./tools/dep_updaters/update-brotli.sh > temp-output
196+
./tools/dep_updaters/update-minimatch.sh > temp-output
195197
cat temp-output
196198
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
197199
rm temp-output
198-
- id: minimatch
200+
- id: nghttp2
199201
subsystem: deps
200202
label: dependencies
201203
run: |
202-
./tools/dep_updaters/update-minimatch.sh > temp-output
204+
./tools/dep_updaters/update-nghttp2.sh > temp-output
203205
cat temp-output
204206
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
205207
rm temp-output
206-
- id: root-certificates
207-
subsystem: crypto
208-
label: crypto, notable-change
209-
run: |
210-
node ./tools/dep_updaters/update-root-certs.mjs -v -f "$GITHUB_ENV"
211-
- id: cjs-module-lexer
208+
- id: nghttp3
212209
subsystem: deps
213210
label: dependencies
214211
run: |
215-
./tools/dep_updaters/update-cjs-module-lexer.sh > temp-output
212+
./tools/dep_updaters/update-nghttp3.sh > temp-output
216213
cat temp-output
217214
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
218215
rm temp-output
@@ -224,43 +221,48 @@ jobs:
224221
cat temp-output
225222
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
226223
rm temp-output
227-
- id: nghttp3
228-
subsystem: deps
229-
label: dependencies
224+
- id: postject
225+
subsystem: deps,test
226+
label: test
230227
run: |
231-
./tools/dep_updaters/update-nghttp3.sh > temp-output
228+
./tools/dep_updaters/update-postject.sh > temp-output
232229
cat temp-output
233230
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
234231
rm temp-output
235-
- id: uvwasi
232+
- id: root-certificates
233+
subsystem: crypto
234+
label: crypto, notable-change
235+
run: |
236+
node ./tools/dep_updaters/update-root-certs.mjs -v -f "$GITHUB_ENV"
237+
- id: simdutf
236238
subsystem: deps
237239
label: dependencies
238240
run: |
239-
./tools/dep_updaters/update-uvwasi.sh > temp-output
241+
./tools/dep_updaters/update-simdutf.sh > temp-output
240242
cat temp-output
241243
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
242244
rm temp-output
243-
- id: zlib
245+
- id: undici
244246
subsystem: deps
245247
label: dependencies
246248
run: |
247-
./tools/dep_updaters/update-zlib.sh > temp-output
249+
./tools/dep_updaters/update-undici.sh > temp-output
248250
cat temp-output
249251
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
250252
rm temp-output
251-
- id: googletest
253+
- id: uvwasi
252254
subsystem: deps
253-
label: dependencies, test
255+
label: dependencies
254256
run: |
255-
./tools/dep_updaters/update-googletest.sh > temp-output
257+
./tools/dep_updaters/update-uvwasi.sh > temp-output
256258
cat temp-output
257259
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
258260
rm temp-output
259-
- id: icu
261+
- id: zlib
260262
subsystem: deps
261-
label: dependencies, test
263+
label: dependencies
262264
run: |
263-
./tools/dep_updaters/update-icu.sh > temp-output
265+
./tools/dep_updaters/update-zlib.sh > temp-output
264266
cat temp-output
265267
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
266268
rm temp-output

0 commit comments

Comments
 (0)