Skip to content

Commit 7458d4e

Browse files
addaleaxMylesBorins
authored andcommitted
build: disable -O3 for C++ coverage
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: #12406 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e512906 commit 7458d4e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

node.gypi

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,8 @@
323323
'-O0' ],
324324
'cflags': [ '--coverage',
325325
'-g',
326-
'-O0' ]
326+
'-O0' ],
327+
'cflags!': [ '-O3' ]
327328
}],
328329
[ 'OS=="sunos"', {
329330
'ldflags': [ '-Wl,-M,/usr/lib/ld/map.noexstk' ],

0 commit comments

Comments
 (0)