src: convert hex2bin() into a regular function

RaisinTen · danielleadams · commit 73ce911a6f32 · 2022-04-23T22:47:21.000-04:00
No need to write hex2bin() as a function template because it's only called with a char parameter. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42321 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -222,8 +222,7 @@ void AppendOrEscape(std::string* str,
     *str += ch;
 }
 
-template <typename T>
-unsigned hex2bin(const T ch) {
+unsigned hex2bin(const char ch) {
   if (ch >= '0' && ch <= '9')
     return ch - '0';
   if (ch >= 'A' && ch <= 'F')

Original file line number	Diff line number	Diff line change
`@@ -222,8 +222,7 @@ void AppendOrEscape(std::string* str,`
`222`	`222`	`*str += ch;`
`223`	`223`	`}`
`224`	`224`
`225`		`-template <typename T>`
`226`		`-unsigned hex2bin(const T ch) {`
	`225`	`+unsigned hex2bin(const char ch) {`
`227`	`226`	`if (ch >= '0' && ch <= '9')`
`228`	`227`	`return ch - '0';`
`229`	`228`	`if (ch >= 'A' && ch <= 'F')`