Skip to content

Commit 721ebf0

Browse files
nehebBethGriggs
authored andcommitted
src: don't use deprecated OpenSSL APIs
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent fe3818e commit 721ebf0

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/node_crypto.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2121,15 +2121,15 @@ static Local<Object> X509ToObject(Environment* env, X509* cert) {
21212121
rsa.reset();
21222122
ec.reset();
21232123

2124-
ASN1_TIME_print(bio.get(), X509_get_notBefore(cert));
2124+
ASN1_TIME_print(bio.get(), X509_get0_notBefore(cert));
21252125
BIO_get_mem_ptr(bio.get(), &mem);
21262126
info->Set(context, env->valid_from_string(),
21272127
String::NewFromUtf8(env->isolate(), mem->data,
21282128
NewStringType::kNormal,
21292129
mem->length).ToLocalChecked()).Check();
21302130
USE(BIO_reset(bio.get()));
21312131

2132-
ASN1_TIME_print(bio.get(), X509_get_notAfter(cert));
2132+
ASN1_TIME_print(bio.get(), X509_get0_notAfter(cert));
21332133
BIO_get_mem_ptr(bio.get(), &mem);
21342134
info->Set(context, env->valid_to_string(),
21352135
String::NewFromUtf8(env->isolate(), mem->data,

src/node_crypto.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@
3535

3636
#include <openssl/err.h>
3737
#include <openssl/ssl.h>
38+
#include <openssl/bn.h>
39+
#include <openssl/dh.h>
40+
#include <openssl/ec.h>
41+
#include <openssl/rsa.h>
3842

3943
namespace node {
4044
namespace crypto {

0 commit comments

Comments
 (0)