diff --git a/lib/net.js b/lib/net.js index 3944b9627c86f1..31f1c31bf3d23d 100644 --- a/lib/net.js +++ b/lib/net.js @@ -574,14 +574,16 @@ function onread(nread, buffer) { debug('EOF'); + // push a null to signal the end of data. + // Do it before `maybeDestroy` for correct order of events: + // `end` -> `close` + self.push(null); + if (self._readableState.length === 0) { self.readable = false; maybeDestroy(self); } - // push a null to signal the end of data. - self.push(null); - // internal end event so that we know that the actual socket // is no longer readable, and we can start the shutdown // procedure. No need to wait for all the data to be consumed. diff --git a/test/parallel/test-net-end-close.js b/test/parallel/test-net-end-close.js new file mode 100644 index 00000000000000..d9f33fd7d8d1cf --- /dev/null +++ b/test/parallel/test-net-end-close.js @@ -0,0 +1,26 @@ +'use strict'; +require('../common'); +const assert = require('assert'); +const net = require('net'); + +const uv = process.binding('uv'); + +const s = new net.Socket({ + handle: { + readStart: function() { + process.nextTick(() => this.onread(uv.UV_EOF, null)); + }, + close: (cb) => process.nextTick(cb) + }, + writable: false +}); +s.resume(); + +const events = []; + +s.on('end', () => events.push('end')); +s.on('close', () => events.push('close')); + +process.on('exit', () => { + assert.deepStrictEqual(events, [ 'end', 'close' ]); +});