Skip to content

Commit 6f1c622

Browse files
daeyeonaduh95
authored andcommitted
src: use Maybe<void> in ProcessEmitWarningSync
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #57250 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5c9f1a4 commit 6f1c622

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/node_process.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ inline v8::Maybe<bool> ProcessEmitWarning(Environment* env,
3737
const char* fmt,
3838
Args&&... args);
3939

40-
v8::Maybe<bool> ProcessEmitWarningSync(Environment* env,
40+
v8::Maybe<void> ProcessEmitWarningSync(Environment* env,
4141
std::string_view message);
4242
v8::Maybe<bool> ProcessEmitExperimentalWarning(Environment* env,
4343
const std::string& warning);

src/node_process_events.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ using v8::Function;
1010
using v8::HandleScope;
1111
using v8::Isolate;
1212
using v8::Just;
13+
using v8::JustVoid;
1314
using v8::Local;
1415
using v8::Maybe;
1516
using v8::MaybeLocal;
@@ -19,7 +20,7 @@ using v8::Object;
1920
using v8::String;
2021
using v8::Value;
2122

22-
Maybe<bool> ProcessEmitWarningSync(Environment* env, std::string_view message) {
23+
Maybe<void> ProcessEmitWarningSync(Environment* env, std::string_view message) {
2324
Isolate* isolate = env->isolate();
2425
Local<Context> context = env->context();
2526
Local<String> message_string;
@@ -28,7 +29,7 @@ Maybe<bool> ProcessEmitWarningSync(Environment* env, std::string_view message) {
2829
NewStringType::kNormal,
2930
static_cast<int>(message.size()))
3031
.ToLocal(&message_string)) {
31-
return Nothing<bool>();
32+
return Nothing<void>();
3233
}
3334

3435
Local<Value> argv[] = {message_string};
@@ -39,9 +40,9 @@ Maybe<bool> ProcessEmitWarningSync(Environment* env, std::string_view message) {
3940
if (emit_function.As<Function>()
4041
->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
4142
.IsEmpty()) {
42-
return Nothing<bool>();
43+
return Nothing<void>();
4344
}
44-
return Just(true);
45+
return JustVoid();
4546
}
4647

4748
MaybeLocal<Value> ProcessEmit(Environment* env,

0 commit comments

Comments
 (0)