Skip to content

Commit 6cf0f62

Browse files
Trottrvagg
authored andcommitted
test: fix spurious EADDRINUSE in test-https-strict
test-https-strict sometimes fails with EADDRINUSE in CI. Remove use of common.PORT to make the test resistant from side effects from other tests that may have not freed up the port. PR-URL: #7024 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent dea120f commit 6cf0f62

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

test/parallel/test-https-strict.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,9 @@ var server3 = server(options3);
6565

6666
var listenWait = 0;
6767

68-
var port = common.PORT;
69-
var port1 = port++;
70-
var port2 = port++;
71-
var port3 = port++;
72-
server1.listen(port1, listening());
73-
server2.listen(port2, listening());
74-
server3.listen(port3, listening());
68+
server1.listen(0, listening());
69+
server2.listen(0, listening());
70+
server3.listen(0, listening());
7571

7672
var responseErrors = {};
7773
var expectResponseCount = 0;
@@ -131,9 +127,9 @@ function makeReq(path, port, error, host, ca) {
131127
}
132128
var req = https.get(options);
133129
expectResponseCount++;
134-
var server = port === port1 ? server1
135-
: port === port2 ? server2
136-
: port === port3 ? server3
130+
var server = port === server1.address().port ? server1
131+
: port === server2.address().port ? server2
132+
: port === server3.address().port ? server3
137133
: null;
138134

139135
if (!server) throw new Error('invalid port: ' + port);
@@ -156,6 +152,10 @@ function makeReq(path, port, error, host, ca) {
156152
function allListening() {
157153
// ok, ready to start the tests!
158154

155+
const port1 = server1.address().port;
156+
const port2 = server2.address().port;
157+
const port3 = server3.address().port;
158+
159159
// server1: host 'agent1', signed by ca1
160160
makeReq('/inv1', port1, 'UNABLE_TO_VERIFY_LEAF_SIGNATURE');
161161
makeReq('/inv1-ca1', port1,

0 commit comments

Comments
 (0)