Skip to content

Commit 6bb057e

Browse files
joaocgreisFishrock123
authored andcommitted
win,build: exit when addons fail to build
PR-URL: #8412 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 14d356d commit 6bb057e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

vcbuild.bat

+4
Original file line numberDiff line numberDiff line change
@@ -343,12 +343,16 @@ for /d %%F in (test\addons\??_*) do (
343343
)
344344
:: generate
345345
"%node_exe%" tools\doc\addon-verify.js
346+
if %errorlevel% neq 0 exit /b %errorlevel%
346347
:: building addons
348+
SetLocal EnableDelayedExpansion
347349
for /d %%F in (test\addons\*) do (
348350
"%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild ^
349351
--directory="%%F" ^
350352
--nodedir="%cd%"
353+
if !errorlevel! neq 0 exit /b !errorlevel!
351354
)
355+
EndLocal
352356
goto run-tests
353357

354358
:run-tests

0 commit comments

Comments
 (0)