test_runner: bound the force-exit flush wait

Ensure --test-force-exit cannot hang if a reporter destination never
signals completion, by capping the per-destination flush wait. The
normal path still clears the timer as soon as the stream finishes, so
a destination that is actively flushing is never cut short.

Signed-off-by: Navaneeth Prabha <nvps742@gmail.com>

Author: Navaneethp007

lib/internal/test_runner/test.js

@@ -94,6 +94,10 @@ const { relative } = require('path');
 const { availableParallelism } = require('os');
 const { innerOk } = require('internal/assert/utils');
 const { bigint: hrtime } = process.hrtime;
+// Upper bound (in milliseconds) on how long --test-force-exit waits for a
+// single reporter destination to flush before giving up, so a forced exit
+// can never hang on a destination that fails to signal completion.
+const kForceExitFlushTimeout = 5000;
 const kCallbackAndPromisePresent = 'callbackAndPromisePresent';
 const kCancelledByParent = 'cancelledByParent';
 const kAborted = 'testAborted';
@@ -1473,9 +1477,22 @@ class Test extends AsyncResource {
         const { destination } = reporterScope.reporters[i];
 
         ArrayPrototypePush(promises, new Promise((resolve) => {
+          // Force exit must never hang. If a destination never signals
+          // completion (for example one that already errored before this
+          // ran), fall back to a bounded timeout so the process.exit() below
+          // cannot be blocked indefinitely. In the normal path the completion
+          // callback fires first and clears this timer, so it never cuts off
+          // a destination that is still flushing. The timer is unref'd so it
+          // does not by itself keep the event loop alive.
+          const timer = setTimeout(resolve, kForceExitFlushTimeout);
+          timer.unref();
+          const done = () => {
+            clearTimeout(timer);
+            resolve();
+          };
           destination.on('unpipe', () => {
             if (!destination.closed && typeof destination.close === 'function') {
-              destination.close(resolve);
+              destination.close(done);
             } else {
               // The destination has no close() to await - for example a child
               // process's stdout, which is a pipe to the test runner's parent
@@ -1489,7 +1506,7 @@ class Test extends AsyncResource {
                   typeof destination._handle.setBlocking === 'function') {
                 destination._handle.setBlocking(true);
               }
-              destination.end(resolve);
+              destination.end(done);
             }
           });
         }));