fixup! src: add support for escaping quotes with escape slash in --env-file

Author: pluris

src/node_dotenv.cc

@@ -52,8 +52,11 @@ void Dotenv::SetEnvironment(node::Environment* env) {
     auto existing = env->env_vars()->Get(key.data());
 
     if (existing.IsNothing()) {
-      // Remove all '\' characters from value
-      value.erase(std::remove(value.begin(), value.end(), '\\'), value.end());
+      size_t found = value.find("\\\"");
+      while (found != std::string::npos) {
+        value.replace(found, 2, "\"");
+        found = value.find("\\\"", found + 1);
+      }
       env->env_vars()->Set(
           isolate,
           v8::String::NewFromUtf8(

test/fixtures/dotenv/valid.env

@@ -30,7 +30,8 @@ EQUAL_SIGNS=equals==
 RETAIN_INNER_QUOTES={"foo": "bar"}
 RETAIN_INNER_QUOTES_AS_STRING='{"foo": "bar"}'
 RETAIN_INNER_QUOTES_AS_BACKTICKS=`{"foo": "bar's"}`
-RETAIN_INNER_QUOTES_AS_ESCAPE_SLASH=`{\"foo\": \"bar\"}`
+RETAIN_INNER_QUOTES_AS_ESCAPE_SLASH="{\"foo\": \"bar\"}"
 TRIM_SPACE_FROM_UNQUOTED=    some spaced out string
 EMAIL=therealnerdybeast@example.tld
     SPACED_KEY = parsed
+PATH_WINDOWS=C:\\Windows\\system32

test/parallel/test-dotenv.js

@@ -69,3 +69,5 @@ assert.strictEqual(process.env.TRIM_SPACE_FROM_UNQUOTED, 'some spaced out string
 assert.strictEqual(process.env.EMAIL, 'therealnerdybeast@example.tld');
 // Parses keys and values surrounded by spaces
 assert.strictEqual(process.env.SPACED_KEY, 'parsed');
+// Parses windows path
+assert.strictEqual(process.env.PATH_WINDOWS, 'C:\\\\Windows\\\\system32');