Skip to content

Commit

Permalink
test: remove workaround code in debugger test
Browse files Browse the repository at this point in the history
Remove code that made a check more lenient to account for a known issue
that is no longer reproducible.

Refs: nodejs/node-inspect#35

PR-URL: #39238
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
  • Loading branch information
Trott authored and targos committed Sep 4, 2021
1 parent 5c6ab71 commit 6852389
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions test/sequential/test-debugger-preserve-breaks.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,19 +53,9 @@ const path = require('path');
})
.then(() => cli.command('breakpoints'))
.then(() => {
// TODO: There is a known issue on AIX and some other operating systems
// where the breakpoints aren't properly resolved yet when we reach this
// point. Eventually that should be figured out but for now we don't
// want to fail builds because of it.
// What it should be:
//
// const msg = `SCRIPT: ${script}, OUTPUT: ${cli.output}`;
// assert.ok(cli.output.includes(`#0 ${script}:2`), msg);
// assert.ok(cli.output.includes(`#1 ${script}:3`), msg);
//
// What we're doing for now instead:
assert.match(cli.output, /#0 [^\n]+three-lines\.js\$?:2/);
assert.match(cli.output, /#1 [^\n]+three-lines\.js\$?:3/);
const msg = `SCRIPT: ${script}, OUTPUT: ${cli.output}`;
assert.ok(cli.output.includes(`#0 ${script}:2`), msg);
assert.ok(cli.output.includes(`#1 ${script}:3`), msg);
})
.then(() => cli.quit())
.then(null, onFatal);
Expand Down

0 comments on commit 6852389

Please sign in to comment.