Skip to content

Commit 678e1be

Browse files
addaleaxmmarchini
authored andcommitted
src: delete CallbackInfo when cleared from cleanup hook
Fixes: #32400 PR-URL: #32405 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f2cc28a commit 678e1be

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_buffer.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,14 @@ void CallbackInfo::WeakCallback(
163163
const WeakCallbackInfo<CallbackInfo>& data) {
164164
CallbackInfo* self = data.GetParameter();
165165
self->WeakCallback(data.GetIsolate());
166-
delete self;
167166
}
168167

169168

170169
void CallbackInfo::WeakCallback(Isolate* isolate) {
171170
callback_(data_, hint_);
172171
int64_t change_in_bytes = -static_cast<int64_t>(sizeof(*this));
173172
isolate->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
173+
delete this;
174174
}
175175

176176

0 commit comments

Comments
 (0)