Skip to content

Commit 673c1fd

Browse files
Trottdanielleadams
authored andcommitted
test: avoid using Object.prototype methods directly on objects
This prepares us to enable the no-prototype-builtins ESLint rule. Refs: https://eslint.org/docs/rules/no-prototype-builtins PR-URL: #41801 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
1 parent 4660c1f commit 673c1fd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

test/parallel/test-console-group.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ function teardown() {
151151
// Check that the kGroupIndent symbol property is not enumerable
152152
{
153153
const keys = Reflect.ownKeys(console)
154-
.filter((val) => console.propertyIsEnumerable(val))
154+
.filter((val) => Object.prototype.propertyIsEnumerable.call(console, val))
155155
.map((val) => val.toString());
156156
assert(!keys.includes('Symbol(groupIndent)'),
157157
'groupIndent should not be enumerable');

test/parallel/test-stream-base-prototype-accessors-enumerability.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ const { internalBinding } = require('internal/test/binding');
1414
const TTY = internalBinding('tty_wrap').TTY;
1515

1616
{
17-
assert.strictEqual(TTY.prototype.propertyIsEnumerable('bytesRead'), false);
18-
assert.strictEqual(TTY.prototype.propertyIsEnumerable('fd'), false);
19-
assert.strictEqual(
20-
TTY.prototype.propertyIsEnumerable('_externalStream'), false);
17+
const ttyIsEnumerable = Object.prototype.propertyIsEnumerable.bind(TTY);
18+
assert.strictEqual(ttyIsEnumerable('bytesRead'), false);
19+
assert.strictEqual(ttyIsEnumerable('fd'), false);
20+
assert.strictEqual(ttyIsEnumerable('_externalStream'), false);
2121
}

0 commit comments

Comments
 (0)