From 66cb8180e4e5d094140cd47e28606645ac790aa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Fri, 20 May 2022 11:33:16 +0200 Subject: [PATCH] doc: use serial comma in assert docs Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43154 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh --- doc/api/assert.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/api/assert.md b/doc/api/assert.md index bf50fb2daadc6a..0a9edcc98b05d9 100644 --- a/doc/api/assert.md +++ b/doc/api/assert.md @@ -535,6 +535,8 @@ are also recursively evaluated by the following rules. objects. * [`Symbol`][] properties are not compared. * [`WeakMap`][] and [`WeakSet`][] comparison does not rely on their values. +* [`RegExp`][] lastIndex, flags, and source are always compared, even if these + are not enumerable properties. The following example does not throw an [`AssertionError`][] because the primitives are compared using the [`==` operator][]. @@ -691,6 +693,8 @@ are recursively evaluated also by the following rules. reference. * [`WeakMap`][] and [`WeakSet`][] comparison does not rely on their values. See below for further details. +* [`RegExp`][] lastIndex, flags, and source are always compared, even if these + are not enumerable properties. ```mjs import assert from 'node:assert/strict'; @@ -958,7 +962,7 @@ benefit in catching a rejection and then rejecting it again. Instead, consider adding a comment next to the specific code path that should not reject and keep error messages as expressive as possible. -If specified, `error` can be a [`Class`][], [`RegExp`][] or a validation +If specified, `error` can be a [`Class`][], [`RegExp`][], or a validation function. See [`assert.throws()`][] for more details. Besides the async nature to await the completion behaves identically to @@ -1040,7 +1044,7 @@ parameter, then an [`AssertionError`][] is thrown. If the error is of a different type, or if the `error` parameter is undefined, the error is propagated back to the caller. -If specified, `error` can be a [`Class`][], [`RegExp`][] or a validation +If specified, `error` can be a [`Class`][], [`RegExp`][], or a validation function. See [`assert.throws()`][] for more details. The following, for instance, will throw the [`TypeError`][] because there is no