http: remove closeIdleConnections function while calling server close

Correcting the #50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18.
This behavior is for node v19 and above.

Fixes: #52330
Fixes: #51677
PR-URL: #52336
Refs: #50194
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

lib/_http_server.js

@@ -506,7 +506,6 @@ function setupConnectionsTracking() {
 }
 
 function httpServerPreClose(server) {
-  server.closeIdleConnections();
   clearInterval(server[kConnectionsCheckingInterval]);
 }
 

test/parallel/test-http-server-close-idle.js

@@ -42,6 +42,7 @@ server.listen(0, function() {
         assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
         assert.strictEqual(connections, 2);
 
+        server.closeIdleConnections();
         server.close(common.mustCall());
 
         // Check that only the idle connection got closed

test/parallel/test-https-server-close-idle.js

@@ -52,6 +52,7 @@ server.listen(0, function() {
         assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
         assert.strictEqual(connections, 2);
 
+        server.closeIdleConnections();
         server.close(common.mustCall());
 
         // Check that only the idle connection got closed