Skip to content

Commit 663d400

Browse files
committed
dns: move setServers to internal/dns/promise.js
1 parent 29ff235 commit 663d400

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

lib/dns.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,6 @@ ObjectDefineProperties(module.exports, {
386386
get() {
387387
if (promises === null) {
388388
promises = require('internal/dns/promises');
389-
promises.setServers = defaultResolverSetServers;
390389
}
391390
return promises;
392391
}

lib/dns/promises.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
'use strict';
22

3-
const dnsPromises = require('internal/dns/promises');
4-
dnsPromises.setServers = require('dns').setServers;
5-
module.exports = dnsPromises;
3+
module.exports = require('internal/dns/promises');

lib/internal/dns/promises.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const {
1717
emitInvalidHostnameWarning,
1818
getDefaultVerbatim,
1919
setDefaultResultOrder,
20+
setDefaultResolver,
2021
} = require('internal/dns/utils');
2122
const { codes, dnsException } = require('internal/errors');
2223
const { toASCII } = require('internal/idna');
@@ -313,6 +314,19 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype) {
313314
return ReflectApply(resolver, this, [hostname]);
314315
};
315316

317+
function defaultResolverSetServers(servers) {
318+
const resolver = new Resolver();
316319

317-
module.exports = { lookup, lookupService, Resolver, setDefaultResultOrder };
320+
resolver.setServers(servers);
321+
setDefaultResolver(resolver);
322+
bindDefaultResolver(module.exports, Resolver.prototype);
323+
}
324+
325+
module.exports = {
326+
lookup,
327+
lookupService,
328+
Resolver,
329+
setDefaultResultOrder,
330+
setServers: defaultResolverSetServers,
331+
};
318332
bindDefaultResolver(module.exports, Resolver.prototype);

0 commit comments

Comments
 (0)