Skip to content

Commit

Permalink
test: guarantee test runs in test-readline-keys
Browse files Browse the repository at this point in the history
Use common.mustCall() to guarantee that test functions (created by a
factory function) are run.

PR-URL: #11023
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Mar 9, 2017
1 parent d8eed12 commit 646f825
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions test/parallel/test-readline-keys.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use strict';
require('../common');
var PassThrough = require('stream').PassThrough;
var assert = require('assert');
var inherits = require('util').inherits;
var extend = require('util')._extend;
var Interface = require('readline').Interface;
const common = require('../common');
const PassThrough = require('stream').PassThrough;
const assert = require('assert');
const inherits = require('util').inherits;
const extend = require('util')._extend;
const Interface = require('readline').Interface;


function FakeInput() {
Expand Down Expand Up @@ -55,7 +55,7 @@ function addTest(sequences, expectedKeys) {

const addKeyIntervalTest = (sequences, expectedKeys, interval = 550,
assertDelay = 550) => {
return (next) => () => {
const fn = common.mustCall((next) => () => {

if (!Array.isArray(sequences)) {
sequences = [ sequences ];
Expand Down Expand Up @@ -84,7 +84,8 @@ const addKeyIntervalTest = (sequences, expectedKeys, interval = 550,
}
};
emitKeys(sequences);
};
});
return fn;
};

// regular alphanumerics
Expand Down

0 comments on commit 646f825

Please sign in to comment.