Skip to content

Commit 6203d05

Browse files
AdamMajeraddaleax
authored andcommitted
test: fix zlib-brotli output assumptions
On different architectures, it's possible for the compression algorithm to produce slightly different outputs. So, don't assume we will always get the same compressed output on all architectures. Instead, verify that the decompressing pre-compressed string functions correctly. Fixes: #25568 PR-URL: #25697 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 77274d0 commit 6203d05

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

test/parallel/test-zlib-brotli-from-string.js

+15-11
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,25 @@ const inputString = 'ΩΩLorem ipsum dolor sit amet, consectetur adipiscing eli'
1414
' diam ipsum. Suspendisse nec ullamcorper odio. Vestibulu' +
1515
'm arcu mi, sodales non suscipit id, ultrices ut massa. S' +
1616
'ed ac sem sit amet arcu malesuada fermentum. Nunc sed. ';
17-
const expectedBase64Compress = 'G/gBQBwHdky2aHV5KK9Snf05//1pPdmNw/7232fnIm1IB' +
18-
'K1AA8RsN8OB8Nb7Lpgk3UWWUlzQXZyHQeBBbXMTQXC1j7' +
19-
'wg3LJs9LqOGHRH2bj/a2iCTLLx8hBOyTqgoVuD1e+Qqdn' +
20-
'f1rkUNyrWq6LtOhWgxP3QUwdhKGdZm3rJWaDDBV7+pDk1' +
21-
'MIkrmjp4ma2xVi5MsgJScA3tP1I7mXeby6MELozrwoBQD' +
22-
'mVTnEAicZNj4lkGqntJe2qSnGyeMmcFgraK94vCg/4iLu' +
23-
'Tw5RhKhnVY++dZ6niUBmRqIutsjf5TzwF5iAg8a9UkjF5' +
24-
'2eZ0tB2vo6v8SqVfNMkBmmhxr0NT9LkYF69aEjlYzj7IE' +
25-
'KmEUQf1HBogRYhFIt4ymRNEgHAIzOyNEsQM=';
17+
const compressedString = 'G/gBQBwHdky2aHV5KK9Snf05//1pPdmNw/7232fnIm1IB' +
18+
'K1AA8RsN8OB8Nb7Lpgk3UWWUlzQXZyHQeBBbXMTQXC1j7' +
19+
'wg3LJs9LqOGHRH2bj/a2iCTLLx8hBOyTqgoVuD1e+Qqdn' +
20+
'f1rkUNyrWq6LtOhWgxP3QUwdhKGdZm3rJWaDDBV7+pDk1' +
21+
'MIkrmjp4ma2xVi5MsgJScA3tP1I7mXeby6MELozrwoBQD' +
22+
'mVTnEAicZNj4lkGqntJe2qSnGyeMmcFgraK94vCg/4iLu' +
23+
'Tw5RhKhnVY++dZ6niUBmRqIutsjf5TzwF5iAg8a9UkjF5' +
24+
'2eZ0tB2vo6v8SqVfNMkBmmhxr0NT9LkYF69aEjlYzj7IE' +
25+
'KmEUQf1HBogRYhFIt4ymRNEgHAIzOyNEsQM=';
2626

2727
zlib.brotliCompress(inputString, common.mustCall((err, buffer) => {
28-
assert.strictEqual(buffer.toString('base64'), expectedBase64Compress);
28+
assert(inputString.length > buffer.length);
29+
30+
zlib.brotliDecompress(buffer, common.mustCall((err, buffer) => {
31+
assert.strictEqual(buffer.toString(), inputString);
32+
}));
2933
}));
3034

31-
const buffer = Buffer.from(expectedBase64Compress, 'base64');
35+
const buffer = Buffer.from(compressedString, 'base64');
3236
zlib.brotliDecompress(buffer, common.mustCall((err, buffer) => {
3337
assert.strictEqual(buffer.toString(), inputString);
3438
}));

0 commit comments

Comments
 (0)