Skip to content

Commit 614ce0c

Browse files
mcollinaBethGriggs
authored andcommitted
deps,http: http_parser set max header size to 8KB
Reapplying HTTP_MAX_HEADER_SIZE=8192 to http_parser.gyp. CVE-2018-12121 PR-URL: nodejs-private/node-private#143 Backport-PR-URL: #30473 Ref: nodejs-private/security#139 Ref: nodejs-private/http-parser-private#2 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent af5c489 commit 614ce0c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

deps/http_parser/http_parser.gyp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
'defines': [ 'HTTP_PARSER_STRICT=0' ],
5757
'include_dirs': [ '.' ],
5858
},
59-
'defines': [ 'HTTP_PARSER_STRICT=0' ],
59+
'defines': [ 'HTTP_MAX_HEADER_SIZE=8192', 'HTTP_PARSER_STRICT=0' ],
6060
'sources': [ './http_parser.c', ],
6161
'conditions': [
6262
['OS=="win"', {
@@ -79,7 +79,7 @@
7979
'defines': [ 'HTTP_PARSER_STRICT=1' ],
8080
'include_dirs': [ '.' ],
8181
},
82-
'defines': [ 'HTTP_PARSER_STRICT=1' ],
82+
'defines': [ 'HTTP_MAX_HEADER_SIZE=8192', 'HTTP_PARSER_STRICT=1' ],
8383
'sources': [ './http_parser.c', ],
8484
'conditions': [
8585
['OS=="win"', {

0 commit comments

Comments
 (0)