From 6058c4349fd89c61cf7feeeeac9186e9842fbb20 Mon Sep 17 00:00:00 2001 From: cool88 Date: Tue, 2 May 2017 23:55:48 +0530 Subject: [PATCH] test: refactored test-repl-persistent-history PR-URL: https://github.com/nodejs/node/pull/12703 Reviewed-By: James M Snell Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen --- test/parallel/test-repl-persistent-history.js | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/test/parallel/test-repl-persistent-history.js b/test/parallel/test-repl-persistent-history.js index f2c760cb38910a..2c31a13119fe2e 100644 --- a/test/parallel/test-repl-persistent-history.js +++ b/test/parallel/test-repl-persistent-history.js @@ -204,12 +204,6 @@ const tests = [ const numtests = tests.length; -let testsNotRan = tests.length; - -process.on('beforeExit', () => - assert.strictEqual(testsNotRan, 0) -); - function cleanupTmpFile() { try { // Write over the file, clearing any history @@ -225,6 +219,8 @@ function cleanupTmpFile() { fs.createReadStream(historyFixturePath) .pipe(fs.createWriteStream(historyPath)).on('unpipe', () => runTest()); +const runTestWrap = common.mustCall(runTest, numtests); + function runTest(assertCleaned) { const opts = tests.shift(); if (!opts) return; // All done @@ -294,8 +290,7 @@ function runTest(assertCleaned) { try { // Ensure everything that we expected was output assert.strictEqual(expected.length, 0); - testsNotRan--; - setImmediate(runTest, cleaned); + setImmediate(runTestWrap, cleaned); } catch (err) { console.error(`Failed test # ${numtests - tests.length}`); throw err;