Skip to content

Commit 60268bd

Browse files
committed
test: remove deadlock workaround
1 parent 6b219ef commit 60268bd

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

test/parallel/test-file-write-stream4.js

+1-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Flags: --expose-gc
21
'use strict';
32

43
// Test that 'close' emits once and not twice when `emitClose: true` is set.
@@ -18,8 +17,4 @@ const fileWriteStream = fs.createWriteStream(filepath, {
1817
});
1918

2019
fileReadStream.pipe(fileWriteStream);
21-
fileWriteStream.on('close', common.mustCall(() => {
22-
// TODO(lpinca): Remove the forced GC when
23-
// https://github.com/nodejs/node/issues/54918 is fixed.
24-
globalThis.gc({ type: 'major' });
25-
}));
20+
fileWriteStream.on('close', common.mustCall());

test/parallel/test-net-write-fully-async-buffer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const server = net.createServer(common.mustCall(function(conn) {
2323
}
2424

2525
while (conn.write(Buffer.from(data)));
26-
globalThis.gc({ type: 'major' });
26+
globalThis.gc({ type: 'minor' });
2727
// The buffer allocated above should still be alive.
2828
}
2929

test/parallel/test-net-write-fully-async-hex-string.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const server = net.createServer(common.mustCall(function(conn) {
2121
}
2222

2323
while (conn.write(data, 'hex'));
24-
globalThis.gc({ type: 'major' });
24+
globalThis.gc({ type: 'minor' });
2525
// The buffer allocated inside the .write() call should still be alive.
2626
}
2727

0 commit comments

Comments
 (0)