Skip to content

Commit

Permalink
tools: install and enable JSDoc linting in ESLint
Browse files Browse the repository at this point in the history
PR-URL: #41027
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
Trott authored and danielleadams committed Dec 13, 2021
1 parent 95868e1 commit 5fe6632
Show file tree
Hide file tree
Showing 328 changed files with 29,867 additions and 18,292 deletions.
6 changes: 5 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ NodePlugin.RULES_DIR = path.resolve(__dirname, 'tools', 'eslint-rules');
const ModuleFindPath = Module._findPath;
const hacks = [
'eslint-plugin-node-core',
'eslint-plugin-jsdoc',
'eslint-plugin-markdown',
'@babel/eslint-parser',
'@babel/plugin-syntax-import-assertions',
Expand All @@ -34,7 +35,7 @@ Module._findPath = (request, paths, isMain) => {

module.exports = {
root: true,
plugins: ['markdown', 'node-core'],
plugins: ['jsdoc', 'markdown', 'node-core'],
parser: '@babel/eslint-parser',
parserOptions: {
babelOptions: {
Expand Down Expand Up @@ -336,6 +337,9 @@ module.exports = {
'use-isnan': 'error',
'valid-typeof': ['error', { requireStringLiterals: true }],

// JSDoc rules
'jsdoc/check-types': 'error',

// Custom rules from eslint-plugin-node-core
'node-core/no-unescaped-regexp-dot': 'error',
'node-core/no-duplicate-requires': 'error',
Expand Down
314 changes: 0 additions & 314 deletions tools/node_modules/eslint/README.md

This file was deleted.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/acorn

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/browserslist

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/eslint

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/js-yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/jsesc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/json5

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/node-which

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/parser

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/rimraf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/node_modules/eslint/node_modules/.bin/semver

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 0 additions & 19 deletions tools/node_modules/eslint/node_modules/@babel/code-frame/README.md

This file was deleted.

19 changes: 0 additions & 19 deletions tools/node_modules/eslint/node_modules/@babel/core/README.md

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5fe6632

Please sign in to comment.